openshift-docs
openshift-docs copied to clipboard
openshift
CNV-33890: Swap feature in CNV RN 4.16
Resolves: https://issues.redhat.com/browse/CNV-33888
OCP 4.16 CNV 4.16
Preview: https://77535--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-16-release-notes.html#virt-4-16-technology-preview
@sbeskin-redhat: This pull request references CNV-33890 which is a valid jira issue.
In response to this:
Resolves: https://issues.redhat.com/browse/CNV-33888
OCP 4.16 CNV 4.16
Preview:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
🤖 Fri Jul 05 14:27:54 - Prow CI generated the docs preview:
https://77535--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-16-release-notes.html
@sbeskin-redhat: This pull request references CNV-33890 which is a valid jira issue.
In response to this:
Resolves: https://issues.redhat.com/browse/CNV-33888
OCP 4.16 CNV 4.16
Preview: https://77535--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-16-release-notes.html#virt-4-16-technology-preview
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@fabiand Sorry, I forgot to mention that this PR is only about the release notes: virt/release_notes/virt-4-16-release-notes.adoc The other files relating to the swap feature (virt-configuring-higher-vm-workload-density.adoc and virt-using-wasp-agent-to-configure-higher-vm-workload-density.adoc) are updated in another PR: https://github.com/openshift/openshift-docs/pull/76344
@sbeskin-redhat, :slightly_smiling_face: I'm looking at the preview and it seems that you already added the prerequisites but still need to add a procedure. Also, I see the previous reviewer's comments that have not been addressed or responded to. I also recommend consulting the repo rules files such as how to document TP features.
:slightly_smiling_face: AFAIK, we normally get peer reviews when we feel our authoring work on the PR is completed, so I suggest that you add the missing procedure, get this PR to a point where you believe that it's ready to be merged, and ask the QE to review and approve it. Also, please remember to squash the commits. And then add the peer-review-needed label.
Since I'm only onboarding for the peer review squad, let's ask for a second opinion or additional feedback from @dfitzmau.
Sorry, I forgot to mention that this PR is only about the release notes: virt/release_notes/virt-4-16-release-notes.adoc The other files relating to the swap feature (virt-configuring-higher-vm-workload-density.adoc and virt-using-wasp-agent-to-configure-higher-vm-workload-density.adoc) are updated in another PR: #76344
@sbeskin-redhat, :slightly_smiling_face: in such a case, please remove the changes that should not be merged with this PR.
Hi @sbeskin-redhat . I agree with Max. The commits need to be squashed, non-intended files should be reverted, and the merge conflict(s) need to be addressed.
@sbeskin-redhat: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@sbeskin-redhat: This pull request references CNV-33890 which is a valid jira issue.
In response to this:
Resolves: https://issues.redhat.com/browse/CNV-33890
OCP 4.16 CNV 4.16
Preview: https://77535--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-16-release-notes.html#virt-4-16-technology-preview
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.