openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

OBSDOCS-736-4.14 - Logging Installation Fix - cee.next

Open libander opened this issue 1 year ago • 13 comments
trafficstars

Version(s): 4.14 - Manual CPs will be created for other branches once all reviews are completed.

Issue: OBSDOCS-736, OBSDOCS-1127

Link to docs preview: https://77407--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/cluster-logging-deploying.html

QE review:

  • [x] QE has approved this change.

Additional information: For reviewers: This PR addresses a cee.next labelled critical customer impacting issue. Please be aware that with the exception of minor wording changes, all of this content was already reviewed / approved / and live on various branches. This PR simply corrects a breaking change in the layout / flow of the installation docs.

libander avatar Jun 13 '24 01:06 libander

@r2d2rnd - This is still building at the moment, and the xrefs might need to be fixed, but the layout should be valid, PTAL when you get a chance. If the build fails I'll fix them when I'm on in the morning.

libander avatar Jun 13 '24 01:06 libander

🤖 Thu Jul 11 19:29:22 - Prow CI generated the docs preview:

https://77407--ocpdocs-pr.netlify.app/ https://77407--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/cluster-logging-deploying.html https://77407--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/logging_alerts/default-logging-alerts.html https://77407--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/log_storage/installing-log-storage.html https://77407--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/log_visualization/log-visualization-ocp-console.html

ocpdocs-previewbot avatar Jun 13 '24 01:06 ocpdocs-previewbot

/test validate-portal

libander avatar Jun 20 '24 10:06 libander

@anpingli / @kabirbhartiRH / @QiaolingTang - Review, please.

libander avatar Jun 21 '24 05:06 libander

/assign anpingli

anpingli avatar Jun 21 '24 08:06 anpingli

Note: From 5.8 and later. cluster-logging operator can be deployed as global operator. The change traces in https://github.com/openshift/openshift-docs/pull/75652. I guess we needn't update this point in this PR.

anpingli avatar Jun 21 '24 08:06 anpingli

/label peer-review-needed

libander avatar Jun 23 '24 01:06 libander

/lgtm

anpingli avatar Jun 24 '24 01:06 anpingli

New changes are detected. LGTM label has been removed.

openshift-ci[bot] avatar Jun 25 '24 11:06 openshift-ci[bot]

/lgtm @anpingli - I changed the oc create to oc apply, can you please take another look to make sure I didn't miss anything?

libander avatar Jun 27 '24 17:06 libander

LGTM

anpingli avatar Jun 28 '24 01:06 anpingli

/label merge-review-needed

libander avatar Jun 28 '24 12:06 libander

/label merge-review-needed

libander avatar Jul 10 '24 15:07 libander

Created https://issues.redhat.com/browse/OBSDOCS-1182 to capture any lingering fixes needed.

libander avatar Jul 11 '24 18:07 libander

@libander: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jul 11 '24 19:07 openshift-ci[bot]