openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

OCPBUGS-34129: Update Minimal permissions for GCP installs

Open barbacbd opened this issue 1 year ago • 11 comments

Version(s):

4.16

Issue:

https://issues.redhat.com/browse/OCPBUGS-34129

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

** Due to the addition of CAPG resources, the installer destroy code requires additional minimal permissions. Even though the minimal install does not use CAPG, the search for resources remains the same no matter the type of install.

** NOTE: This does not include the ability to delete these new resources as that is not part of the minimal install and destroy, these additional permissions allow the user to list those resources.

barbacbd avatar May 23 '24 12:05 barbacbd

@barbacbd: This pull request references Jira Issue OCPBUGS-34129, which is invalid:

  • expected the bug to target either version "4.17." or "openshift-4.17.", but it targets "4.16.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):

4.16

Issue:

https://issues.redhat.com/browse/OCPBUGS-34129

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

** Due to the addition of CAPG resources, the installer destroy code requires additional minimal permissions. Even though the minimal install does not use CAPG, the search for resources remains the same no matter the type of install.

** NOTE: This does not include the ability to delete these new resources as that is not part of the minimal install and destroy, these additional permissions allow the user to list those resources.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 23 '24 12:05 openshift-ci-robot

/cc @bscott-rh

barbacbd avatar May 23 '24 12:05 barbacbd

/jira-refresh

barbacbd avatar May 23 '24 12:05 barbacbd

🤖 Wed Jul 17 19:28:11 - Prow CI generated the docs preview:

https://76407--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_gcp/installing-gcp-account.html https://76407--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_gcp/installing-gcp-user-infra.html https://76407--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_gcp/installing-restricted-networks-gcp.html

ocpdocs-previewbot avatar May 23 '24 12:05 ocpdocs-previewbot

LGTM from docs perspective.

bscott-rh avatar May 23 '24 12:05 bscott-rh

/lgtm

bfournie avatar Jun 07 '24 16:06 bfournie

/jira refresh

barbacbd avatar Jun 11 '24 14:06 barbacbd

@barbacbd: This pull request references Jira Issue OCPBUGS-34129, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @jianli-wei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 11 '24 14:06 openshift-ci-robot

The branch/enterprise-4.17 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.16. And any PR going into main must also target the latest version branch (enterprise-4.17).

If the update in your PR does NOT apply to version 4.17 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

kalexand-rh avatar Jun 26 '24 22:06 kalexand-rh

/lgtm

bfournie avatar Jul 03 '24 19:07 bfournie

Peer review LGTM.

bscott-rh avatar Jul 17 '24 18:07 bscott-rh

@barbacbd Please squash the commits to 1 before merge.

ShaunaDiaz avatar Jul 17 '24 18:07 ShaunaDiaz

@barbacbd: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jul 17 '24 19:07 openshift-ci[bot]

/lgtm

bfournie avatar Jul 17 '24 19:07 bfournie

@barbacbd: Jira Issue OCPBUGS-34129: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-34129 has been moved to the MODIFIED state.

In response to this:

Version(s):

4.16

Issue:

https://issues.redhat.com/browse/OCPBUGS-34129

Link to docs preview: https://76407--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_gcp/installing-gcp-account.html https://76407--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_gcp/installing-gcp-user-infra.html https://76407--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_gcp/installing-restricted-networks-gcp.html

QE review:

  • [ ] QE has approved this change.

Additional information:

** Due to the addition of CAPG resources, the installer destroy code requires additional minimal permissions. Even though the minimal install does not use CAPG, the search for resources remains the same no matter the type of install.

** NOTE: This does not include the ability to delete these new resources as that is not part of the minimal install and destroy, these additional permissions allow the user to list those resources.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 18 '24 16:07 openshift-ci-robot

/cherrypick enterprise-4.16

bscott-rh avatar Jul 18 '24 16:07 bscott-rh

/cherrypick enterprise-4.17

bscott-rh avatar Jul 18 '24 16:07 bscott-rh

@bscott-rh: new pull request created: #79084

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bscott-rh: new pull request created: #79085

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.