openshift-docs
openshift-docs copied to clipboard
openshift
OSDOCS#10333: Removed Alibaba references
Version(s): 4.16
Issue: https://issues.redhat.com/browse/OSDOCS-10333
Link to docs preview: https://75756--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_alibaba/preparing-to-install-on-alibaba
QE review:
- [ ] QE has approved this change.
🤖 Tue Jun 18 07:06:44 - Prow CI generated the docs preview: https://75756--ocpdocs-pr.netlify.app Complete list of updated preview URLs: artifacts/updated_preview_urls.txt
I'd expect you'll need to remove more than this, because your preview still uses the installer to destroy Alibaba clusters, while openshift/installer#7832 (SPLAT-1345) removed Alibaba entirely from the installer, including dropping github.com/openshift/installer/pkg/destroy/alibabacloud.
I'd expect you'll need to remove more than this, because your preview still uses the installer to destroy Alibaba clusters, while openshift/installer#7832 (SPLAT-1345) removed Alibaba entirely from the installer, including dropping
github.com/openshift/installer/pkg/destroy/alibabacloud.
@wking Thanks for taking a look. This PR is still WIP. The plan is to replace the current Alibaba docs with a one-pager that eventually points to Assisted Installer docs and Alibaba docs (if applicable).
From what I see, it looks like we're removing all the existing Alibaba doc pages and replacing with a 1-pager pointing to the Assisted Installer. We need this to say Tech Preview, i.e. OpenShift on Alibaba Cloud with Assisted Installer with platform=none will be considered Technology Preview.
Can we keep / modify the Preparing to install on Alibaba Cloud and Creating the required Alibaba Cloud resources pages or provide some guidance to the user as to how to prepare prior to installing with the Assisted Installer. I'm thinking of something similar to Creating OCI infrastructure resources and services and https://docs.openshift.com/container-platform/4.15/installing/installing_oci/installing-oci-agent-based-installer.html#creating-config-files-cluster-install-oci_installing-oci-agent-based-installer and https://docs.openshift.com/container-platform/4.15/installing/installing_oci/installing-oci-agent-based-installer.html#configuring-firewall_installing-oci-agent-based-installer then run the Assisted Installer.
Also in order to use the Assisted Installer, where are we documenting the instructions on how to do the discovery ISO conversion to QCOW2, specifying the QCOW2, and any other Alibaba specific things that need to happen to bring up the cluster?
CC @faermanj
@julienlim Thanks for your comments!
- So can we mention that the users can install using this section which is TP for Alibaba?
- I can restore the Preparing section. Is the entire content still valid? I did check with some stakeholders of this feature regarding any specific prep instructions that might be needed but didn't get any info. Do we have any?
- As per my discussion with Julio, installing image conversion tools and related info will be a part of AI docs.
@snarayan-redhat Yes we can mention section.
RE Preparing section, please cross reference with the OCI links I posted earlier as those "core pieces" still need to get done but in Alibaba Cloud, check with @faermanj on what updates are needed.
Is the image conversion tool piece mentioned in the Assisted Installer docs?
@julienlim @snarayan-redhat
- Just to clarify, all the steps I documented are regarding the Agent Installer, I believe it fits within the AI documentation
- We'll add the tech preview clarification
- I added the steps to install and run the image conversion tool
- Besides documenting the necessary resources, using the web console, i added a template to let users create everything automatically if they prefer
I'll setup this repo to build the docs and check further, thanks for the comments. Also, I'm going through the steps to verify once more and fix any issues.
If there are modules that might be relevant for installing Alibaba Cloud with Assisted Installer, could you move them to _unused_modules? Thanks!
If there are modules that might be relevant for installing Alibaba Cloud with Assisted Installer, could you move them to _unused_modules? Thanks!
@apinnick IIUC, you would want to move the deleted modules to _unused_modules folder instead?
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
Currently, all the removed modules are specific to IPI. There are no relevant modules that can be retained for installing using AI.
@snarayan-redhat I recommend having someone from the ROSA team also check and ack their pages for changes (I see changes listed for both ROSA and Dedicated).
I'd expect you'll need to remove more than this, because your preview still uses the installer to destroy Alibaba clusters, while openshift/installer#7832 (SPLAT-1345) removed Alibaba entirely from the installer, including dropping
github.com/openshift/installer/pkg/destroy/alibabacloud.@wking Thanks for taking a look. This PR is still WIP. The plan is to replace the current Alibaba docs with a one-pager that eventually points to Assisted Installer docs and Alibaba docs (if applicable).
@snarayan-redhat The preview still shows this content.
@ShaunaDiaz Thanks for suggesting! I will have someone from ROSA do a quick check. Regarding the uninstall bit, I have already mentioned in the description the reason for retaining that assembly. The content will be changed by the AI writer, the file stays.
Reviewed https://75756--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_alibaba/uninstall-cluster-alibaba which LGTM for uninstalling OpenShift cluster in Alibaba Cloud. It should also include mention of cleaning up of the Alibaba infra resources used for the OpenShift cluster (mentioned in the preparing to install OpenShift section) should be deleted (so as to avoid unnecessary cloud charges if you no longer require the resources).
@snarayan-redhat: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@snarayan-redhat: new pull request created: #77610
In response to this:
/cherrypick enterprise-4.16
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
