"drop" config should be an array in ClusterLogForwarder

[dhgautam99]

trafficstars

When creating CLF with "drop" log record functionality:

cat clf.yaml 
apiVersion: logging.openshift.io/v1
kind: ClusterLogForwarder
metadata:
  name: instance
  namespace: openshift-logging
spec:
  filters:
  - name: important
    type: drop
    drop:
      test:
      - field: .kubernetes.namespace_name
        matches: "^open"
      test:
      - field: .log_type
        matches: "application"
      - field: .kubernetes.pod_name
        notMatches: "my-pod"
  pipelines:
  - name: test 
    filterRefs: ["abc"]
    inputRefs:
    - application
    outputRefs:
    - default

$ oc create -f clf.yaml The ClusterLogForwarder "instance" is invalid: spec.filters[0].drop: Invalid value: "object": spec.filters[0].drop in body must be of type array: "object"

"drop" should be an array and same is correct in the docs.

Version(s): RHOCP 4.13, 4.14, 4.15

Issue:

Link to docs preview:

QE review:

• [ ] QE has approved this change.

Additional information:

[openshift-ci[bot]]

Hi @dhgautam99. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[libander]

QE: @kabirbhartiRH / @anpingli - Review, please?

[kabirbhartiRH]

/lgtm

[ocpdocs-previewbot]

🤖 Fri Jun 14 19:18:56 - Prow CI generated the docs preview:

https://75742--ocpdocs-pr.netlify.app/openshift-dedicated/latest/observability/logging/performance_reliability/logging-content-filtering.html https://75742--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/performance_reliability/logging-content-filtering.html https://75742--ocpdocs-pr.netlify.app/openshift-rosa/latest/observability/logging/performance_reliability/logging-content-filtering.html

[libander]

/ok-to-test

[openshift-ci[bot]]

@dhgautam99: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[libander]

/label merge-review-needed

[adellape]

/cherrypick enterprise-4.17

[adellape]

/cherrypick enterprise-4.16

[adellape]

/cherrypick enterprise-4.15

[adellape]

/cherrypick enterprise-4.14

[adellape]

/cherrypick enterprise-4.13

[openshift-cherrypick-robot]

@adellape: new pull request created: #80098

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@adellape: new pull request created: #80099

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@adellape: new pull request created: #80100

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@adellape: new pull request created: #80101

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@adellape: new pull request created: #80102

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[adellape]

@dhgautam99 @libander I've merged and cherrypicked this to OCP 4.13, 4.14, and 4.15 as listed in the PR description.

I also created cherrypick PRs for 4.16 and 4.17 but haven't merged them yet. I assume this PR is also now relevant for 4.16 and 4.17 but it just wasn't mentioned in the description when the PR was opened since 4.16 wasn't published yet. Can one of you confirm? I'll leave merge labels on until resolved either way. Thanks!