openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

OSDOCS-10463: vsphere multiple NIC updated

Open dfitzmau opened this issue 9 months ago • 18 comments

Version(s): 4.16+

Issue:

Link to docs preview:

  • [x] SME has approved this change.
  • [x] QE has approved this change.

Additional information:

dfitzmau avatar May 09 '24 10:05 dfitzmau

@dfitzmau: This pull request references OSDOCS-10463 which is a valid jira issue.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 09 '24 10:05 openshift-ci-robot

@dfitzmau: This pull request references OSDOCS-10463 which is a valid jira issue.

In response to this:

Version(s): 4.16

Issue:

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 09 '24 10:05 openshift-ci-robot

🤖 Thu Jul 11 09:58:18 - Prow CI generated the docs preview:

https://75717--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_aws/ipi/installing-aws-network-customizations.html https://75717--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_azure/ipi/installing-azure-network-customizations.html https://75717--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_azure_stack_hub/installing-azure-stack-hub-network-customizations.html https://75717--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/installing-bare-metal-network-customizations.html https://75717--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_gcp/installing-gcp-network-customizations.html https://75717--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_ibm_cloud_public/installing-ibm-cloud-network-customizations.html https://75717--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_vsphere/ipi/installing-vsphere-installer-provisioned-network-customizations.html https://75717--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_vsphere/upi/installing-vsphere-network-customizations.html

ocpdocs-previewbot avatar May 09 '24 10:05 ocpdocs-previewbot

@dfitzmau: This pull request references OSDOCS-10463 which is a valid jira issue.

In response to this:

Version(s): 4.16

Issue:

Link to docs preview:

  • [] SME has approved this change.
  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 10 '24 09:05 openshift-ci-robot

@dfitzmau: This pull request references OSDOCS-10463 which is a valid jira issue.

In response to this:

Version(s): 4.16

Issue:

Link to docs preview:

  • [] SME has approved this change.
  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 10 '24 10:05 openshift-ci-robot

@dfitzmau: This pull request references OSDOCS-10463 which is a valid jira issue.

In response to this:

NEED TO PASS TO BEN NEMEC WHEN TWO OTHER PRs are merged.

Version(s): 4.16

Issue:

Link to docs preview:

  • [] SME has approved this change.
  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 14 '24 10:05 openshift-ci-robot

@dfitzmau: This pull request references OSDOCS-10463 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.17." or "openshift-4.17.", but it targets "openshift-4.16" instead.

In response to this:

Version(s): 4.16

Issue:

Link to docs preview:

  • [] SME has approved this change.
  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 21 '24 16:05 openshift-ci-robot

@dfitzmau: This pull request references OSDOCS-10463 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.17." or "openshift-4.17.", but it targets "openshift-4.16" instead.

In response to this:

Version(s): 4.16

Issue:

Link to docs preview:

  • [x] SME has approved this change.
  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 05 '24 08:06 openshift-ci-robot

/label peer-review-needed

dfitzmau avatar Jun 05 '24 09:06 dfitzmau

@dfitzmau asked a couple questions in slack, answering here for simplicity

What could happen if one does not set the same IP address?

this depends on their configuration. if they are only using a single NIC, then it should work as expected. But, if they have multiple NICs, then it is possible that the CCM would choose the wrong NIC because it would be using the operating system ordering.

If they want to switch to a multiple NIC environment, it's a case of just updating the IP address for the CIDRs (they must be different)?

that's correct, although since this is a cluster-wide configuration they will need to ensure that the machines have the proper NICs and configurations as well. (eg do all the nodes have NICs on the proper CIDRs, etc).

elmiko avatar Jun 05 '24 12:06 elmiko

I found a multi-NIC DHCP DNS race condition on baremetal, OCPBUGS-35317.

I haven't reproduced on vSphere, but the issue is that we don't have a way to select which DNS is used in resolv-prepender.sh. With Multi-NIC we could select a network that doesn't have access to quay.io.

So maybe we need to adjust the Quay.io note like

All NICs must have access to Quay.io to obtain the packages that are required to install your cluster.

rbbratta avatar Jun 13 '24 00:06 rbbratta

This looks good so far, but I'm still testing vSphere Multi-NIC.

rbbratta avatar Jun 13 '24 00:06 rbbratta

Thanks, Ross. I'll hold this PR until https://issues.redhat.com/browse/OCPBUGS-35317 is closed.

dfitzmau avatar Jun 13 '24 08:06 dfitzmau

@dfitzmau: This pull request references OSDOCS-10463 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.17." or "openshift-4.17.", but it targets "openshift-4.16" instead.

In response to this:

Version(s): 4.16

Issue:

Link to docs preview:

  • [x] SME has approved this change.
  • [x] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 17 '24 08:06 openshift-ci-robot

The branch/enterprise-4.17 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.16. And any PR going into main must also target the latest version branch (enterprise-4.17).

If the update in your PR does NOT apply to version 4.17 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

kalexand-rh avatar Jun 26 '24 22:06 kalexand-rh

@dfitzmau: This pull request references OSDOCS-10463 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.17." or "openshift-4.17.", but it targets "openshift-4.16" instead.

In response to this:

Version(s): 4.16+

Issue:

Link to docs preview:

  • [x] SME has approved this change.
  • [x] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 27 '24 13:06 openshift-ci-robot

/lgtm

cybertron avatar Jul 09 '24 16:07 cybertron

/remove-label peer-review-done

dfitzmau avatar Jul 10 '24 09:07 dfitzmau

New changes are detected. LGTM label has been removed.

openshift-ci[bot] avatar Jul 10 '24 09:07 openshift-ci[bot]

Additional peer review needed as subsequent changes followed after the initial review.

/label peer-review-needed

dfitzmau avatar Jul 10 '24 09:07 dfitzmau

/label merge-review-needed

dfitzmau avatar Jul 10 '24 16:07 dfitzmau

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jul 11 '24 09:07 openshift-ci[bot]

/cherrypick enterprise-4.17

jeana-redhat avatar Jul 11 '24 11:07 jeana-redhat

/cherrypick enterprise-4.16

jeana-redhat avatar Jul 11 '24 11:07 jeana-redhat

@jeana-redhat: new pull request created: #78770

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jeana-redhat: new pull request created: #78771

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.