openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

OSDOCS#10239: Simplify upgrading scenarios for hosted control planes

Open xenolinux opened this issue 9 months ago • 2 comments

This PR:

  • Moves the "Upgrading requirements" section to its own assembly
  • Tries to simplify/ correct the wording.

Version(s): 4.14+

Issue: https://issues.redhat.com/browse/OSDOCS-10239

Link to docs preview:

File added to this location: https://75715--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hosted_control_planes/hcp-updating.html

File deleted from the following location: https://75715--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hosted_control_planes/index.html

QE review:

  • [ ] QE has approved this change.

Additional information:

xenolinux avatar May 09 '24 08:05 xenolinux

🤖 Tue May 21 09:35:46 - Prow CI generated the docs preview:

https://75715--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hosted_control_planes/hcp-updating.html

ocpdocs-previewbot avatar May 09 '24 08:05 ocpdocs-previewbot

/lgtm

LiangquanLi930 avatar May 13 '24 08:05 LiangquanLi930

/label peer-review-needed

xenolinux avatar May 13 '24 14:05 xenolinux

/lgtm

csrwng avatar May 13 '24 14:05 csrwng

/label peer-review-in-progress /remove-label peer-review-needed

shipsing avatar May 14 '24 06:05 shipsing

/label peer-review-done

shipsing avatar May 14 '24 08:05 shipsing

New changes are detected. LGTM label has been removed.

openshift-ci[bot] avatar May 14 '24 14:05 openshift-ci[bot]

/label merge-review-needed

xenolinux avatar May 21 '24 09:05 xenolinux

mce and mce-short are displayed as attributes instead of the values. Once reverted, this would be good to merge.

snarayan-redhat avatar May 21 '24 09:05 snarayan-redhat

mce and mce-short are displayed as attributes instead of the values. Once reverted, this would be good to merge.

Done. Reverted the names.

xenolinux avatar May 21 '24 09:05 xenolinux

@xenolinux: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar May 21 '24 09:05 openshift-ci[bot]

/cherrypick enterprise-4.14

snarayan-redhat avatar May 21 '24 10:05 snarayan-redhat

/cherrypick enterprise-4.15

snarayan-redhat avatar May 21 '24 10:05 snarayan-redhat

/cherrypick enterprise-4.16

snarayan-redhat avatar May 21 '24 10:05 snarayan-redhat

@snarayan-redhat: #75715 failed to apply on top of branch "enterprise-4.14":

Applying: OSDOCS#10239: Simplify upgrading scenarios for hosted control planes
Using index info to reconstruct a base tree...
A	modules/hcp-updating-requirements.adoc
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): modules/hcp-updating-requirements.adoc deleted in HEAD and modified in OSDOCS#10239: Simplify upgrading scenarios for hosted control planes. Version OSDOCS#10239: Simplify upgrading scenarios for hosted control planes of modules/hcp-updating-requirements.adoc left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OSDOCS#10239: Simplify upgrading scenarios for hosted control planes
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@snarayan-redhat: new pull request created: #76279

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@snarayan-redhat: new pull request created: #76280

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xenolinux 4.14 needs manual CP. Let me know once it's created and I can merge it.

snarayan-redhat avatar May 21 '24 10:05 snarayan-redhat