openshift-docs
openshift-docs copied to clipboard
OSDOCS#10469: Removed inapplicable architecture content in ROSA/OSD docs
Version(s): 4.15+
Issue: https://issues.redhat.com/browse/OSDOCS-10469
Link to docs preview:
-
OSD Docs Update: Control plane architecture
-
ROSA Docs Update: Control plane architecture
Peer review:
- [ ] Peer reviewer has approved this change.
SME review:
- [ ] SME has approved this change.
QE review:
- [x] QE has approved this change.
Additional information:
🤖 Thu May 16 17:14:47 - Prow CI generated the docs preview:
https://75649--ocpdocs-pr.netlify.app/openshift-dedicated/latest/architecture/control-plane.html https://75649--ocpdocs-pr.netlify.app/openshift-enterprise/latest/architecture/control-plane.html https://75649--ocpdocs-pr.netlify.app/openshift-rosa/latest/architecture/control-plane.html
/label peer-review-needed
/remove-label peer-review-needed /label peer-review-in-progress
/remove-label peer-review-in-progress /label peer-review-done
Previous page https://75649--ocpdocs-pr.netlify.app/openshift-rosa/latest/architecture/rosa-architecture-models lists two topologies - Classic and HCP. This page is ambiguous on whether it refers to Classic or HCP.
LGTM from QE
suggest to add label qe-review-done
/cc @sergiordlr JFYI
@rioliu-rh: GitHub didn't allow me to request PR reviews from the following users: JFYI.
Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.
In response to this:
/cc @sergiordlr JFYI
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Previous page https://75649--ocpdocs-pr.netlify.app/openshift-rosa/latest/architecture/rosa-architecture-models lists two topologies - Classic and HCP. This page is ambiguous on whether it refers to Classic or HCP.
Thanks @bchandra-ocp. If alright with you, I will update this PR to say it does not refer to HCP. I will then create a new ticket under the HCP Documentation Migration epic to migrate this Control plane content to the new section of product documentation for ROSA HCP if applicable. From talking to Ben, he didn't reuse any of the OCP HCP content in the ROSA docs, because it's not really applicable. But I will investigate further.
/label merge-review-needed
/label merge-review-in-progress
/remove-label merge-review-needed
/remove-label merge-review-in-progress
@AedinC Please squash the commits, then LGTM for merge. You can either put it back in queue or ping me directly.
/retest
@AedinC: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
/cherrypick enterprise-4.15
/cherrypick enterprise-4.16
@ShaunaDiaz: new pull request created: #76104
In response to this:
/cherrypick enterprise-4.15
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@ShaunaDiaz: new pull request created: #76105
In response to this:
/cherrypick enterprise-4.16
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.