RHDEVDOCS-5591: Content changes as per SME feedback

[Dhruv-Soni11]

trafficstars

Version(s):

GitOps 1.13

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5591

Link to docs preview:

https://75384--ocpdocs-pr.netlify.app/openshift-gitops/latest/accesscontrol_usermanagement/configuring-argo-cd-rbac.html

SME review: @svghadi QE review: @varshab1210 Internal Peer review: @eromanova97 Peer review:

QE review:

• [ ] QE has approved this change.

Additional information:

[openshift-ci-robot]

@Dhruv-Soni11: This pull request references RHDEVDOCS-5591 which is a valid jira issue.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

• [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ocpdocs-previewbot]

🤖 Tue May 14 13:40:53 - Prow CI generated the docs preview:

https://75384--ocpdocs-pr.netlify.app/openshift-gitops/latest/accesscontrol_usermanagement/configuring-argo-cd-rbac.html

[openshift-ci-robot]

@Dhruv-Soni11: This pull request references RHDEVDOCS-5591 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.13

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5591

Link to docs preview:

SME review: @svghadi QE review: @varshab1210 Internal Peer review: @eromanova97 Peer review:

QE review:

• [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@Dhruv-Soni11: This pull request references RHDEVDOCS-5591 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.13

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5591

Link to docs preview:

https://75384--ocpdocs-pr.netlify.app/openshift-gitops/latest/accesscontrol_usermanagement/configuring-argo-cd-rbac.html

SME review: @svghadi QE review: @varshab1210 Internal Peer review: @eromanova97 Peer review:

QE review:

• [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[varshab1210]

LGTM, thanks

[openshift-ci[bot]]

New changes are detected. LGTM label has been removed.

[Dhruv-Soni11]

/label peer-review-needed

[tmalove]

/remove-label peer-review-needed /label peer-review-in-progress

[tmalove]

/remove-label peer-review-in-progress /label peer-review-done

[Dhruv-Soni11]

/label merge-review-needed

[Dhruv-Soni11]

Hi @kcarmichael08, I appreciate the last-minute suggestions before the eventual merge. I have gone ahead and incorporated your feedback. PTAL and let me know what you think. Thank you.

[openshift-ci[bot]]

@Dhruv-Soni11: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[kcarmichael08]

/cherrypick gitops-docs-1.13

[openshift-cherrypick-robot]

@kcarmichael08: #75384 failed to apply on top of branch "gitops-docs-1.13":

Applying: RHDEVDOCS-5591: Content changes as per SME feedback
Using index info to reconstruct a base tree...
M	accesscontrol_usermanagement/configuring-argo-cd-rbac.adoc
Falling back to patching base and 3-way merge...
Auto-merging accesscontrol_usermanagement/configuring-argo-cd-rbac.adoc
CONFLICT (content): Merge conflict in accesscontrol_usermanagement/configuring-argo-cd-rbac.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 RHDEVDOCS-5591: Content changes as per SME feedback
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick gitops-docs-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[kcarmichael08]

Hi, looks like the cherry pick to 1.13 is failing - can you please create a manual cherry pick? TY!

[Dhruv-Soni11]

Hi, looks like the cherry pick to 1.13 is failing - can you please create a manual cherry pick? TY!

Hi, I have created the manual cherry pick for the GitOps 1.13 in this [PR]https://github.com/openshift/openshift-docs/pull/75970). PTAL.