openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

[enterprise-4.14] OCPBUGS#33114: Doc improvements related to metrics, must-gather, and updating LVM Storage

Open sr1kar99 opened this issue 9 months ago • 9 comments

Version(s): 4.14

Issue: OCPBUGS-33114

Link to docs preview: Preview

QE review:

  • [x] QE has approved this change.

sr1kar99 avatar Apr 30 '24 07:04 sr1kar99

🤖 Mon May 13 18:20:35 - Prow CI generated the docs preview:

https://75331--ocpdocs-pr.netlify.app/ https://75331--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/persistent_storage/persistent_storage_local/persistent-storage-using-lvms.html

ocpdocs-previewbot avatar Apr 30 '24 07:04 ocpdocs-previewbot

@suleymanakbas91 Could you please review this PR? Thanks!

sr1kar99 avatar May 06 '24 11:05 sr1kar99

/lgtm

suleymanakbas91 avatar May 06 '24 15:05 suleymanakbas91

@radeore Can you please review this PR? Thanks!

sr1kar99 avatar May 07 '24 04:05 sr1kar99

/lgtm

radeore avatar May 09 '24 20:05 radeore

/label peer-review-needed

sr1kar99 avatar May 10 '24 04:05 sr1kar99

Nice enhancements! :)

One question about version applibaility: this says 4.14, but the bug it's addressing says 4.13, 4.14. Can you confirm which version(s) this impacts?

/remove-label peer-review-in-progress /remove-label peer-review-needed /label peer-review-done

@jeana-redhat Thanks for the review! :)

Yes! You are right. I will be creating another PR for 4.13 after closing the PRs for 4.14 doc improvements.

sr1kar99 avatar May 11 '24 13:05 sr1kar99

New changes are detected. LGTM label has been removed.

openshift-ci[bot] avatar May 11 '24 13:05 openshift-ci[bot]

/label merge-review-needed

sr1kar99 avatar May 13 '24 14:05 sr1kar99

@sr1kar99, looks like this conflicts with the other PR and needs a conflict resolution.

jab-rh avatar May 13 '24 15:05 jab-rh

/remove-label merge-review-needed

ShaunaDiaz avatar May 13 '24 17:05 ShaunaDiaz

/label merge-review-needed

ShaunaDiaz avatar May 13 '24 17:05 ShaunaDiaz

@sr1kar99: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar May 13 '24 18:05 openshift-ci[bot]

@sr1kar99, looks like this conflicts with the other PR and needs a conflict resolution.

@jab-rh Resolved the conflicts. Could you please merge this PR? Thanks!

sr1kar99 avatar May 13 '24 18:05 sr1kar99

lgtm for merge

kcarmichael08 avatar May 13 '24 19:05 kcarmichael08