CNV#21150: instance types API

[ousleyp]

trafficstars

Version(s): 4.15+

Issue: CNV-21150

Links to docs preview:

Primary pages updated

• https://75235--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/virtual_machines/creating_vms_rh/virt-creating-vms-from-cli.html
• https://75235--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/virtual_machines/creating_vms_rh/virt-creating-vms-from-instance-types.html
• https://75235--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/getting_started/virt-using-the-cli-tools.html#vm-manifest-creation-commands_virt-using-the-cli-tools

New YAMLs

• https://75235--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/virtual_machines/virt-accessing-vm-ssh.html#virt-adding-public-key-cli_static-key static key
• https://75235--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/virtual_machines/virt-accessing-vm-ssh.html#virt-adding-public-key-cli_dynamic-key dynamic key

Minor updates

• https://75235--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/getting_started/virt-getting-started.html

QE review:

• [x] QE has approved this change.

Additional information:

[ocpdocs-previewbot]

🤖 Mon May 13 18:20:12 - Prow CI generated the docs preview: https://75235--ocpdocs-pr.netlify.app Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

[lyarwood]

/lgtm

[ousleyp]

@RoniKishner Hi, can you please review this PR from the QE perspective? Thank you!

[mburke5678]

@ousleyp Overall looks good. A few suggestions/questions. I am not sure what you changed in Configuring SSH access to virtual machines, however. Otherwise LGTM.

[ousleyp]

@ousleyp Overall looks good. A few suggestions/questions. I am not sure what you changed in Configuring SSH access to virtual machines, however. Otherwise LGTM.

Great question. It was in this list of build preview links and I lazily assumed I had forgotten some random change... my apologies for the confusion!

Thanks so much for the thoughtful review, as always, @mburke5678 !

[dominikholler]

Great to see this documented!

Can the example yaml in "Creating a VM from a VirtualMachine manifest" in https://docs.openshift.com/container-platform/4.15/virt/virtual_machines/creating_vms_rh/virt-creating-vms-from-cli.html#virt-creating-vm-cli_virt-creating-vms-cli be also adopted to use instancetypes?

A very minimalistic VM would be

 apiVersion: kubevirt.io/v1
 kind: VirtualMachine
 metadata:
  name: rhel-9-minimal
 spec:
  dataVolumeTemplates:
    - metadata:
        name: rhel-9-minimal-volume
      spec:
        sourceRef:
          kind: DataSource
          name: rhel9
          namespace: openshift-virtualization-os-images
        storage: {}
  instancetype:
    name: u1.medium
  preference:
    name: rhel.9
  running: true
  template:
    spec:
      domain:
        devices: {}
      volumes:
        - dataVolume:
            name: rhel-9-minimal-volume
          name: rootdisk

[ousleyp]

Great to see this documented!

Can the example yaml in "Creating a VM from a VirtualMachine manifest" in https://docs.openshift.com/container-platform/4.15/virt/virtual_machines/creating_vms_rh/virt-creating-vms-from-cli.html#virt-creating-vm-cli_virt-creating-vms-cli be also adopted to use instancetypes?

Great suggestion, thanks! I just changed that example to the manifest you provided and attempted to give some additional information in the callouts. Can you please review, @dominikholler ? Thanks!

[ousleyp]

@dominikholler , thanks for the feedback! I have added a link to the SSH page and a note regarding the lack of authentication config to this PR, but I have not yet updated the YAMLs on the SSH page. That page is a little complicated because it uses one YAML with conditionals to cover both static and dynamic. I'll work on making that update shortly.

[ousleyp]

@dominikholler , I changed up the YAMLs on the SSH page. Please take a look when you can; thanks! :)

Here are the preview build pages that are specific to those YAMLs: https://75235--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/virtual_machines/virt-accessing-vm-ssh.html#virt-adding-public-key-cli_static-key static key https://75235--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/virtual_machines/virt-accessing-vm-ssh.html#virt-adding-public-key-cli_dynamic-key dynamic key

[dominikholler]

@lyarwood @akrejcir can you please have a look, too?

[ousleyp]

Hi @lyarwood @akrejcir , I can merge this if it LGTY, so please let me know when you've taken a look. Thank you!

[openshift-ci[bot]]

New changes are detected. LGTM label has been removed.

[openshift-ci[bot]]

@ousleyp: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[ousleyp]

/cherrypick enterprise-4.15

[ousleyp]

/cherrypick enterprise-4.16

[openshift-cherrypick-robot]

@ousleyp: new pull request created: #75875

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@ousleyp: new pull request created: #75876

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.