openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

OCPBUGS#32769: Adding dockercfg to list of types of secrets

Open bergerhoffer opened this issue 1 year ago • 12 comments
trafficstars

Version(s): 4.12+

Issue: https://issues.redhat.com/browse/OCPBUGS-32769

Link to docs preview: https://75082--ocpdocs-pr.netlify.app/openshift-enterprise/latest/nodes/pods/nodes-pods-secrets.html#nodes-pods-secrets-about-types_nodes-pods-secrets

QE review:

  • [x] QE has approved this change.

Additional information:

bergerhoffer avatar Apr 24 '24 14:04 bergerhoffer

🤖 Thu May 09 18:51:04 - Prow CI generated the docs preview:

https://75082--ocpdocs-pr.netlify.app/openshift-dedicated/latest/nodes/pods/nodes-pods-secrets.html https://75082--ocpdocs-pr.netlify.app/openshift-enterprise/latest/nodes/pods/nodes-pods-secrets.html https://75082--ocpdocs-pr.netlify.app/openshift-rosa/latest/nodes/pods/nodes-pods-secrets.html

ocpdocs-previewbot avatar Apr 24 '24 14:04 ocpdocs-previewbot

@sanchezl Can you please review to make sure this looks okay to you?

Preview: https://75082--ocpdocs-pr.netlify.app/openshift-enterprise/latest/nodes/pods/nodes-pods-secrets.html#nodes-pods-secrets-about-types_nodes-pods-secrets

bergerhoffer avatar Apr 24 '24 15:04 bergerhoffer

/peer-review-needed

bergerhoffer avatar Apr 24 '24 16:04 bergerhoffer

@xingxingxia or @dpuniaredhat Can one of you please QE review this?

Preview: https://75082--ocpdocs-pr.netlify.app/openshift-enterprise/latest/nodes/pods/nodes-pods-secrets.html#nodes-pods-secrets-about-types_nodes-pods-secrets

bergerhoffer avatar Apr 24 '24 16:04 bergerhoffer

/label peer-review-needed

bergerhoffer avatar Apr 24 '24 16:04 bergerhoffer

/label peer-review-in-progress

jneczypor avatar Apr 24 '24 17:04 jneczypor

/remove-label peer-review-in-progress /remove-label peer-review-needed /label peer-review-done

jneczypor avatar Apr 24 '24 17:04 jneczypor

LGTM

michaelryanpeter avatar Apr 24 '24 17:04 michaelryanpeter

/lgtm

xingxingxia avatar May 09 '24 04:05 xingxingxia

@bergerhoffer: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar May 09 '24 18:05 openshift-ci[bot]

@xingxingxia Mind giving this another quick look to make sure you're okay with the change luis suggested here?

https://github.com/openshift/openshift-docs/pull/75082#discussion_r1595624162

bergerhoffer avatar May 09 '24 19:05 bergerhoffer

/lgtm

xingxingxia avatar May 10 '24 05:05 xingxingxia

/cherrypick enterprise-4.16

bergerhoffer avatar Jun 05 '24 15:06 bergerhoffer

/cherrypick enterprise-4.15

bergerhoffer avatar Jun 05 '24 15:06 bergerhoffer

/cherrypick enterprise-4.14

bergerhoffer avatar Jun 05 '24 15:06 bergerhoffer

/cherrypick enterprise-4.13

bergerhoffer avatar Jun 05 '24 15:06 bergerhoffer

/cherrypick enterprise-4.12

bergerhoffer avatar Jun 05 '24 15:06 bergerhoffer

@bergerhoffer: new pull request created: #76999

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bergerhoffer: new pull request created: #77000

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bergerhoffer: new pull request created: #77001

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bergerhoffer: new pull request created: #77002

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bergerhoffer: new pull request created: #77003

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.