openshift-docs
openshift-docs copied to clipboard
RHDEVDOCS-5958: Table header correction for tables using the ** style in it's headers
Version(s): GitOps 1.10, GitOps 1.11, GitOps 1.12, GitOps 1.13
Issue: https://issues.redhat.com/browse/RHDEVDOCS-5958
Link to docs preview: The following tables include the table header change:
- Argo CD custom resource properties - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/argocd_instance/argo-cd-cr-component-properties#argo-cd-properties_argo-cd-cr-component-properties
- In-built permissions for cluster configuration - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/declarative_clusterconfig/configuring-an-openshift-cluster-by-deploying-an-application-with-cluster-configurations#gitops-inbuilt-permissions-for-cluster-config_configuring-an-openshift-cluster-by-deploying-an-application-with-cluster-configurations
- Modifying RHSSO resource requests/limits - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/accesscontrol_usermanagement/configuring-argo-cd-rbac#modifying-rhsso-resource-requests-limits_configuring-argo-cd-rbac
- Repo server properties - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/argocd_instance/argo-cd-cr-component-properties#argo-repo-server-properties_argo-cd-cr-component-properties
- Compatibility and support matrix - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/release_notes/gitops-release-notes#GitOps-compatibility-support-matrix_gitops-release-notes
- Monitoring the GitOps Operator performance - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/observability/monitoring/monitoring-the-gitops-operator-performance
SME review: @reginapizza QE review: @varshab1210 Internal Peer review: @eromanova97 Peer review:
QE review:
- [ ] QE has approved this change.
@Dhruv-Soni11: This pull request references RHDEVDOCS-5958 which is a valid jira issue.
In response to this:
Version(s):
Issue:
Link to docs preview:
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@Dhruv-Soni11: This pull request references RHDEVDOCS-5958 which is a valid jira issue.
In response to this:
Version(s):
GitOps 1.10, GitOps 1.11, GitOps 1.12
Issue:
https://issues.redhat.com/browse/RHDEVDOCS-5958
Link to docs preview:
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@Dhruv-Soni11: This pull request references RHDEVDOCS-5958 which is a valid jira issue.
In response to this:
Version(s):
GitOps 1.10, GitOps 1.11, GitOps 1.12
Issue:
https://issues.redhat.com/browse/RHDEVDOCS-5958
Link to docs preview:
SME review: @reginapizza QE review: @varshab1210 Peer review:
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@Dhruv-Soni11: This pull request references RHDEVDOCS-5958 which is a valid jira issue.
In response to this:
Version(s):
GitOps 1.10, GitOps 1.11, GitOps 1.12, GitOps 1.13
Issue:
https://issues.redhat.com/browse/RHDEVDOCS-5958
Link to docs preview:
SME review: @reginapizza QE review: @varshab1210 Peer review:
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
🤖 Tue May 14 08:18:09 - Prow CI generated the docs preview:
https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/accesscontrol_usermanagement/configuring-argo-cd-rbac.html https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/argocd_instance/argo-cd-cr-component-properties.html https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/declarative_clusterconfig/configuring-an-openshift-cluster-by-deploying-an-application-with-cluster-configurations.html https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/observability/monitoring/monitoring-the-gitops-operator-performance.html https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/release_notes/gitops-release-notes.html
@Dhruv-Soni11: This pull request references RHDEVDOCS-5958 which is a valid jira issue.
In response to this:
Version(s):
GitOps 1.10, GitOps 1.11, GitOps 1.12, GitOps 1.13
Issue:
https://issues.redhat.com/browse/RHDEVDOCS-5958
Link to docs preview:
The following tables include the table header change:
Monitoring the GitOps Operator performance - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/observability/monitoring/monitoring-the-gitops-operator-performance.html
Argo CD custom resource properties - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/argocd_instance/argo-cd-cr-component-properties#argo-cd-properties_argo-cd-cr-component-properties
In-built permissions for cluster configuration - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/declarative_clusterconfig/configuring-an-openshift-cluster-by-deploying-an-application-with-cluster-configurations#gitops-inbuilt-permissions-for-cluster-config_configuring-an-openshift-cluster-by-deploying-an-application-with-cluster-configurations
Modifying RHSSO resource requests/limits - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/accesscontrol_usermanagement/configuring-argo-cd-rbac#modifying-rhsso-resource-requests-limits_configuring-argo-cd-rbac
Repo server properties - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/argocd_instance/argo-cd-cr-component-properties#argo-repo-server-properties_argo-cd-cr-component-properties
Compatibility and support matrix - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/release_notes/gitops-release-notes#GitOps-compatibility-support-matrix_gitops-release-notes
Monitoring the GitOps Operator performance - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/observability/monitoring/monitoring-the-gitops-operator-performance
SME review: @reginapizza QE review: @varshab1210 Peer review:
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@Dhruv-Soni11: This pull request references RHDEVDOCS-5958 which is a valid jira issue.
In response to this:
Version(s):
GitOps 1.10, GitOps 1.11, GitOps 1.12, GitOps 1.13
Issue:
https://issues.redhat.com/browse/RHDEVDOCS-5958
Link to docs preview:
The following tables include the table header change:
Argo CD custom resource properties - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/argocd_instance/argo-cd-cr-component-properties#argo-cd-properties_argo-cd-cr-component-properties
In-built permissions for cluster configuration - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/declarative_clusterconfig/configuring-an-openshift-cluster-by-deploying-an-application-with-cluster-configurations#gitops-inbuilt-permissions-for-cluster-config_configuring-an-openshift-cluster-by-deploying-an-application-with-cluster-configurations
Modifying RHSSO resource requests/limits - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/accesscontrol_usermanagement/configuring-argo-cd-rbac#modifying-rhsso-resource-requests-limits_configuring-argo-cd-rbac
Repo server properties - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/argocd_instance/argo-cd-cr-component-properties#argo-repo-server-properties_argo-cd-cr-component-properties
Compatibility and support matrix - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/release_notes/gitops-release-notes#GitOps-compatibility-support-matrix_gitops-release-notes
Monitoring the GitOps Operator performance - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/observability/monitoring/monitoring-the-gitops-operator-performance
SME review: @reginapizza QE review: @varshab1210 Peer review:
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@Dhruv-Soni11: This pull request references RHDEVDOCS-5958 which is a valid jira issue.
In response to this:
Version(s): GitOps 1.10, GitOps 1.11, GitOps 1.12, GitOps 1.13
Issue: https://issues.redhat.com/browse/RHDEVDOCS-5958
Link to docs preview: The following tables include the table header change:
- Argo CD custom resource properties - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/argocd_instance/argo-cd-cr-component-properties#argo-cd-properties_argo-cd-cr-component-properties
- In-built permissions for cluster configuration - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/declarative_clusterconfig/configuring-an-openshift-cluster-by-deploying-an-application-with-cluster-configurations#gitops-inbuilt-permissions-for-cluster-config_configuring-an-openshift-cluster-by-deploying-an-application-with-cluster-configurations
- Modifying RHSSO resource requests/limits - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/accesscontrol_usermanagement/configuring-argo-cd-rbac#modifying-rhsso-resource-requests-limits_configuring-argo-cd-rbac
- Repo server properties - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/argocd_instance/argo-cd-cr-component-properties#argo-repo-server-properties_argo-cd-cr-component-properties
- Compatibility and support matrix - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/release_notes/gitops-release-notes#GitOps-compatibility-support-matrix_gitops-release-notes
- Monitoring the GitOps Operator performance - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/observability/monitoring/monitoring-the-gitops-operator-performance
SME review: @reginapizza QE review: @varshab1210 Peer review:
QE review:
- [ ] QE has approved this change.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@Dhruv-Soni11: This pull request references RHDEVDOCS-5958 which is a valid jira issue.
In response to this:
Version(s): GitOps 1.10, GitOps 1.11, GitOps 1.12, GitOps 1.13
Issue: https://issues.redhat.com/browse/RHDEVDOCS-5958
Link to docs preview: The following tables include the table header change:
- Argo CD custom resource properties - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/argocd_instance/argo-cd-cr-component-properties#argo-cd-properties_argo-cd-cr-component-properties
- In-built permissions for cluster configuration - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/declarative_clusterconfig/configuring-an-openshift-cluster-by-deploying-an-application-with-cluster-configurations#gitops-inbuilt-permissions-for-cluster-config_configuring-an-openshift-cluster-by-deploying-an-application-with-cluster-configurations
- Modifying RHSSO resource requests/limits - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/accesscontrol_usermanagement/configuring-argo-cd-rbac#modifying-rhsso-resource-requests-limits_configuring-argo-cd-rbac
- Repo server properties - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/argocd_instance/argo-cd-cr-component-properties#argo-repo-server-properties_argo-cd-cr-component-properties
- Compatibility and support matrix - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/release_notes/gitops-release-notes#GitOps-compatibility-support-matrix_gitops-release-notes
- Monitoring the GitOps Operator performance - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/observability/monitoring/monitoring-the-gitops-operator-performance
SME review: @reginapizza QE review: @varshab1210 Peer review:
QE review:
- [ ] QE has approved this change.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@Dhruv-Soni11: This pull request references RHDEVDOCS-5958 which is a valid jira issue.
In response to this:
Version(s): GitOps 1.10, GitOps 1.11, GitOps 1.12, GitOps 1.13
Issue: https://issues.redhat.com/browse/RHDEVDOCS-5958
Link to docs preview: The following tables include the table header change:
- Argo CD custom resource properties - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/argocd_instance/argo-cd-cr-component-properties#argo-cd-properties_argo-cd-cr-component-properties
- In-built permissions for cluster configuration - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/declarative_clusterconfig/configuring-an-openshift-cluster-by-deploying-an-application-with-cluster-configurations#gitops-inbuilt-permissions-for-cluster-config_configuring-an-openshift-cluster-by-deploying-an-application-with-cluster-configurations
- Modifying RHSSO resource requests/limits - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/accesscontrol_usermanagement/configuring-argo-cd-rbac#modifying-rhsso-resource-requests-limits_configuring-argo-cd-rbac
- Repo server properties - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/argocd_instance/argo-cd-cr-component-properties#argo-repo-server-properties_argo-cd-cr-component-properties
- Compatibility and support matrix - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/release_notes/gitops-release-notes#GitOps-compatibility-support-matrix_gitops-release-notes
- Monitoring the GitOps Operator performance - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/observability/monitoring/monitoring-the-gitops-operator-performance
SME review: @reginapizza QE review: @varshab1210 Peer review:
QE review:
- [ ] QE has approved this change.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@Dhruv-Soni11: This pull request references RHDEVDOCS-5958 which is a valid jira issue.
In response to this:
Version(s): GitOps 1.10, GitOps 1.11, GitOps 1.12, GitOps 1.13
Issue: https://issues.redhat.com/browse/RHDEVDOCS-5958
Link to docs preview: The following tables include the table header change:
- Argo CD custom resource properties - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/argocd_instance/argo-cd-cr-component-properties#argo-cd-properties_argo-cd-cr-component-properties
- In-built permissions for cluster configuration - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/declarative_clusterconfig/configuring-an-openshift-cluster-by-deploying-an-application-with-cluster-configurations#gitops-inbuilt-permissions-for-cluster-config_configuring-an-openshift-cluster-by-deploying-an-application-with-cluster-configurations
- Modifying RHSSO resource requests/limits - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/accesscontrol_usermanagement/configuring-argo-cd-rbac#modifying-rhsso-resource-requests-limits_configuring-argo-cd-rbac
- Repo server properties - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/argocd_instance/argo-cd-cr-component-properties#argo-repo-server-properties_argo-cd-cr-component-properties
- Compatibility and support matrix - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/release_notes/gitops-release-notes#GitOps-compatibility-support-matrix_gitops-release-notes
- Monitoring the GitOps Operator performance - https://74878--ocpdocs-pr.netlify.app/openshift-gitops/latest/observability/monitoring/monitoring-the-gitops-operator-performance
SME review: @reginapizza QE review: @varshab1210 Internal Peer review: @eromanova97 Peer review:
QE review:
- [ ] QE has approved this change.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/label peer-review-needed
@Dhruv-Soni11 LGTM. I am not clear on your response to the comment on bolding the second row of one table. You suggested that you "fixed" it; but I don't see the change, if you intended to add the bold.
@Dhruv-Soni11 LGTM. I am not clear on your response to the comment on bolding the second row of one table. You suggested that you "fixed" it; but I don't see the change, if you intended to add the bold.
Hi @mburke5678 - I have made the change now. Sorry about this.
/label needs-merge-review
@Dhruv-Soni11: The label(s) /label needs-merge-review
cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, cloud-experts, cnv, dev-tools, distributed-tracing, ims, jira/valid-bug, merge-review-in-progress, merge-review-needed, mtc, multi-arch, oadp, peer-review-done, peer-review-in-progress, peer-review-needed, rhacs, rhv, sd-docs, serverless, service-mesh, sme-review-done, sme-review-needed, staff-eng-approved, telco
. Is this label configured under labels -> additional_labels
or labels -> restricted_labels
in plugin.yaml
?
In response to this:
/label needs-merge-review
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/label merge-review-needed
/label merge-review-needed
Hello again, I think merging https://github.com/openshift/openshift-docs/pull/74766 caused all of your other PRs to require rebasing prior to merge. I'll remove the merge label for now.
Merging https://github.com/openshift/openshift-docs/pull/74766 most likely caused your other PRs to require rebasing prior to merge. Removing the merge review label for now.
@Dhruv-Soni11: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
Hi @sheriff-rh, I have gone ahead and rebased the branch to ensure there aren't any conflicts. Added the merge-review-needed label here to ensure that we can resume the process. Thanks.
/label merge-review-needed
Correct @Dhruv-Soni11 , if a PR is ready for merge, add the merge-review-label
as you have done :+1: this week's rotation of merge squad will pick it up when they can.
/cherrypick gitops-docs-1.10
/cherrypick gitops-docs-1.11
/cherrypick gitops-docs-1.12
@Srivaralakshmi: #74878 failed to apply on top of branch "gitops-docs-1.10":
Applying: RHDEVDOCS-5958: Table header correction using the ** style
Using index info to reconstruct a base tree...
M modules/gitops-argo-cd-properties.adoc
M modules/go-compatibility-and-support-matrix.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/go-compatibility-and-support-matrix.adoc
CONFLICT (content): Merge conflict in modules/go-compatibility-and-support-matrix.adoc
Auto-merging modules/gitops-argo-cd-properties.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 RHDEVDOCS-5958: Table header correction using the ** style
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to this:
/cherrypick gitops-docs-1.10
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@Srivaralakshmi: #74878 failed to apply on top of branch "gitops-docs-1.11":
Applying: RHDEVDOCS-5958: Table header correction using the ** style
Using index info to reconstruct a base tree...
M modules/gitops-argo-cd-properties.adoc
M modules/go-compatibility-and-support-matrix.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/go-compatibility-and-support-matrix.adoc
CONFLICT (content): Merge conflict in modules/go-compatibility-and-support-matrix.adoc
Auto-merging modules/gitops-argo-cd-properties.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 RHDEVDOCS-5958: Table header correction using the ** style
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to this:
/cherrypick gitops-docs-1.11
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@Srivaralakshmi: new pull request created: #75900
In response to this:
/cherrypick gitops-docs-1.12
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.