openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

TELCODOCS-1837: Fix erroneous example in day 1 bare metal networking config

Open zaneb opened this issue 1 year ago • 9 comments
trafficstars

There is no "nmstate" key under "networkConfig" inside the install-config, as can be observed from all of the other examples. (The "nmstate" key is where the NMState data lives in the Secret generated from the install-config to associate with the BareMetalHost, or by the user when adding nodes on Day 2.)

Version(s): 4.12-4.16

(also affects 4.10-4.11)

Issue: https://issues.redhat.com/browse/TELCODOCS-1837

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

zaneb avatar Apr 16 '24 02:04 zaneb

@zaneb: This pull request references TELCODOCS-1837 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

There is no "nmstate" key under "networkConfig" inside the install-config, as can be observed from all of the other examples. (The "nmstate" key is where the NMState data lives in the Secret generated from the install-config to associate with the BareMetalHost, or by the user when adding nodes on Day 2.)

Version(s): 4.10-4.16

Issue: https://issues.redhat.com/browse/TELCODOCS-1837

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Apr 16 '24 02:04 openshift-ci-robot

/cc @johnwilkins

zaneb avatar Apr 16 '24 02:04 zaneb

🤖 Tue Apr 16 02:37:18 - Prow CI generated the docs preview:

https://74680--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal_ipi/ipi-install-installation-workflow.html

ocpdocs-previewbot avatar Apr 16 '24 02:04 ocpdocs-previewbot

@zaneb: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Apr 16 '24 02:04 openshift-ci[bot]

/lgtm

bfournie avatar May 01 '24 17:05 bfournie

/label peer-review-needed

johnwilkins avatar May 09 '24 19:05 johnwilkins

Also FYI that the PR will require QE review before it can get merged, I'm not sure who the QE is for this area though

skopacz1 avatar May 09 '24 20:05 skopacz1

/cc @jadhaj

zaneb avatar May 10 '24 00:05 zaneb

@zaneb: This pull request references TELCODOCS-1837 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

There is no "nmstate" key under "networkConfig" inside the install-config, as can be observed from all of the other examples. (The "nmstate" key is where the NMState data lives in the Secret generated from the install-config to associate with the BareMetalHost, or by the user when adding nodes on Day 2.)

Version(s): 4.12-4.16

(also affects 4.10-4.11)

Issue: https://issues.redhat.com/browse/TELCODOCS-1837

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 10 '24 03:05 openshift-ci-robot

/lgtm

jadhaj avatar May 16 '24 06:05 jadhaj

/label merge-review-needed

johnwilkins avatar May 16 '24 16:05 johnwilkins

/remove-label merge-review-needed

ShaunaDiaz avatar May 16 '24 19:05 ShaunaDiaz

/cherrypick enterprise-4.12

ShaunaDiaz avatar May 16 '24 19:05 ShaunaDiaz

/cherrypick enterprise-4.13

ShaunaDiaz avatar May 16 '24 19:05 ShaunaDiaz

/cherrypick enterprise-4.14

ShaunaDiaz avatar May 16 '24 19:05 ShaunaDiaz

/cherrypick enterprise-4.15

ShaunaDiaz avatar May 16 '24 19:05 ShaunaDiaz

/cherrypick enterprise-4.16

ShaunaDiaz avatar May 16 '24 19:05 ShaunaDiaz

@ShaunaDiaz: new pull request created: #76109

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ShaunaDiaz: new pull request created: #76110

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ShaunaDiaz: new pull request created: #76111

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ShaunaDiaz: new pull request created: #76112

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ShaunaDiaz: new pull request created: #76113

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.