openshift-docs
openshift-docs copied to clipboard
TELCODOCS-1683 QinQ support in SR-IOV Network Operator 1
[TELCODOCS-1683]: Docs and RN: CNF-9990 QinQ support in SR-IOV Network Operator (GA)
Version(s): 4.16
Issue: https://issues.redhat.com/browse/TELCODOCS-1683
Link to docs preview: https://74534--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/hardware_networks/configuring-sriov-qinq-support.html
QE review:
- [ ] QE has approved this change.
Additional information:
🤖 Wed May 29 08:31:04 - Prow CI generated the docs preview:
https://74534--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/hardware_networks/configuring-sriov-qinq-support.html
@mlguerrero12 @gkopels How this look now I made the latest update from Greg. WDYT ?
/label peer-review-needed
/label peer-review-in-progress
/remove-label peer-review-in-progress /remove-label peer-review-needed /label peer-review-done
lgtm
@mlguerrero12 change applied hopefully OK now
/lgtm
New changes are detected. LGTM label has been removed.
/label merge-review-needed
I see a "peer-review needed" label on this PR along with merge labels. THis PR is in the peer review queue so the "peer-review-needed" label should be removed? Unless more changes sparked an additional peer review?
@dfitzmau this was peer-reviewed already. I added in error to the queue again.
/remove-label peer-review-needed
@kquinn1204 A couple of nits I hope you would consider before merging.
Thank you @mburke5678 I have updated with your suggestions. Hopefully good to merge now.
/label merge-review-needed
@kquinn1204: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@adellape thanks for your feedback hopefully this is OK to publish now.
/cherrypick enterprise-4.16
@adellape: new pull request created: #76661
In response to this:
/cherrypick enterprise-4.16
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.