openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

TELCODOCS-1683 QinQ support in SR-IOV Network Operator 1

Open kquinn1204 opened this issue 1 year ago • 2 comments
trafficstars

[TELCODOCS-1683]: Docs and RN: CNF-9990 QinQ support in SR-IOV Network Operator (GA)

Version(s): 4.16

Issue: https://issues.redhat.com/browse/TELCODOCS-1683

Link to docs preview: https://74534--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/hardware_networks/configuring-sriov-qinq-support.html

QE review:

  • [ ] QE has approved this change.

Additional information:

kquinn1204 avatar Apr 11 '24 15:04 kquinn1204

🤖 Wed May 29 08:31:04 - Prow CI generated the docs preview:

https://74534--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/hardware_networks/configuring-sriov-qinq-support.html

ocpdocs-previewbot avatar Apr 11 '24 15:04 ocpdocs-previewbot

@mlguerrero12 @gkopels How this look now I made the latest update from Greg. WDYT ?

kquinn1204 avatar May 16 '24 13:05 kquinn1204

/label peer-review-needed

kquinn1204 avatar May 21 '24 08:05 kquinn1204

/label peer-review-in-progress

agantony avatar May 21 '24 09:05 agantony

/remove-label peer-review-in-progress /remove-label peer-review-needed /label peer-review-done

agantony avatar May 21 '24 12:05 agantony

lgtm

gkopels avatar May 22 '24 10:05 gkopels

@mlguerrero12 change applied hopefully OK now

kquinn1204 avatar May 23 '24 08:05 kquinn1204

/lgtm

mlguerrero12 avatar May 28 '24 08:05 mlguerrero12

New changes are detected. LGTM label has been removed.

openshift-ci[bot] avatar May 28 '24 08:05 openshift-ci[bot]

/label merge-review-needed

kquinn1204 avatar May 28 '24 08:05 kquinn1204

I see a "peer-review needed" label on this PR along with merge labels. THis PR is in the peer review queue so the "peer-review-needed" label should be removed? Unless more changes sparked an additional peer review?

dfitzmau avatar May 28 '24 08:05 dfitzmau

@dfitzmau this was peer-reviewed already. I added in error to the queue again.

kquinn1204 avatar May 28 '24 08:05 kquinn1204

/remove-label peer-review-needed

kquinn1204 avatar May 28 '24 08:05 kquinn1204

@kquinn1204 A couple of nits I hope you would consider before merging.

mburke5678 avatar May 28 '24 13:05 mburke5678

Thank you @mburke5678 I have updated with your suggestions. Hopefully good to merge now.

kquinn1204 avatar May 28 '24 14:05 kquinn1204

/label merge-review-needed

kquinn1204 avatar May 28 '24 16:05 kquinn1204

@kquinn1204: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar May 29 '24 08:05 openshift-ci[bot]

@adellape thanks for your feedback hopefully this is OK to publish now.

kquinn1204 avatar May 29 '24 15:05 kquinn1204

/cherrypick enterprise-4.16

adellape avatar May 29 '24 16:05 adellape

@adellape: new pull request created: #76661

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.