openshift-docs
openshift-docs copied to clipboard
openshift
OSDOCS-10020: CPMS per-provider breakout
Version(s): 4.15+
Issue: OSDOCS-10020
Link to docs preview:
- Managing control plane machines with control plane machine sets
- Sections in subdir "Configuration options for control plane machines"
QE review:
- [ ] QE has approved this change.
Additional information:
- will attempt further cherrypicks (beyond 4.15) to see how complex they are
🤖 Fri May 10 16:42:01 - Prow CI generated the docs preview: https://73646--ocpdocs-pr.netlify.app Complete list of updated preview URLs: artifacts/updated_preview_urls.txt
can one of @sunzhaohua2 @huali9 or @miyadav PTAL for QE? This PR is primarily updating the organization of the CPMS book to separate out different providers (since the AWS user probably is not too interested in what they can do on GCP).
LGTM @sunzhaohua2 Can you double check the azure and openstack part? @miyadav Can you double check the gcp and vsphere part? Thank you! As there are many features can be enabled by CPMS on these platforms which I am not sure.
LGTM @sunzhaohua2 Can you double check the azure and openstack part? @miyadav Can you double check the gcp and vsphere part? Thank you! As there are many features can be enabled by CPMS on these platforms which I am not sure.
I updated the QE checkbox section at the top based on this comment. I put you by Nutanix and AWS since they are the ones you didn't ask the others about :) Appreciate the team effort!
As long as QE are happy with the Azure notes that have changed, then I think this is good from my side
Thanks! CC @huali9 does this look right now?
- Postinstallation version (both providers)
- AWS CPMS version
- Azure CPMS version
@jeana-redhat: This pull request references OSDOCS-10020 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
In response to this:
Version(s): 4.15+
Issue: OSDOCS-10020
Link to docs preview: Most pages in the Managing control plane machines directory (first assembly is About control plane machine sets)
QE review:
- [ ] @huali9 aws and nutanix
- [x] @sunzhaohua2 azure and openstack
- [ ] @miyadav gcp and vsphere
Additional information:
- ToDo: resolve this https://github.com/openshift/openshift-docs/pull/73646#discussion_r1568338387
- will attempt further cherrypicks (beyond 4.15) to see how complex they are
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@jeana-redhat: This pull request references OSDOCS-10020 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
In response to this:
Version(s): 4.15+
Issue: OSDOCS-10020
Link to docs preview: Most pages in the Managing control plane machines directory (first assembly is About control plane machine sets)
QE review:
- [ ] @huali9 aws and nutanix
- [x] @sunzhaohua2 azure and openstack
- [x] @miyadav gcp and vsphere
Additional information:
- ToDo: resolve this https://github.com/openshift/openshift-docs/pull/73646#discussion_r1568338387
- will attempt further cherrypicks (beyond 4.15) to see how complex they are
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@jeana-redhat: This pull request references OSDOCS-10020 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
In response to this:
Version(s): 4.15+
Issue: OSDOCS-10020
Link to docs preview: Most pages in the Managing control plane machines directory (first assembly is About control plane machine sets)
QE review:
- [x] @huali9 aws and nutanix
- [x] @sunzhaohua2 azure and openstack
- [x] @miyadav gcp and vsphere
Additional information:
- will attempt further cherrypicks (beyond 4.15) to see how complex they are
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
No new feedback since updating 29 April, will squash and send for peer review. Thanks all!
@jeana-redhat: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@jeana-redhat: #73646 failed to apply on top of branch "enterprise-4.15":
Applying: OSDOCS-10020: CPMS per-provider breakout
Using index info to reconstruct a base tree...
M _attributes/common-attributes.adoc
M _topic_maps/_topic_map.yml
M machine_management/control_plane_machine_management/cpmso-getting-started.adoc
M modules/cpmso-yaml-failure-domain-vsphere.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/cpmso-yaml-failure-domain-vsphere.adoc
CONFLICT (content): Merge conflict in modules/cpmso-yaml-failure-domain-vsphere.adoc
Removing machine_management/control_plane_machine_management/cpmso-using.adoc
Auto-merging machine_management/control_plane_machine_management/cpmso-getting-started.adoc
Auto-merging _topic_maps/_topic_map.yml
Auto-merging _attributes/common-attributes.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OSDOCS-10020: CPMS per-provider breakout
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to this:
/cherrypick enterprise-4.15
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@jeana-redhat: new pull request created: #75784
In response to this:
/cherrypick enterprise-4.16
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.