openshift-docs
openshift-docs copied to clipboard
TELCODOCS-1785 Improving NROP documentation
[TELCODOCS-1785]: Improving NROP documentation
Version(s): 4.12 >
Issue: https://issues.redhat.com/browse/TELCODOCS-1785
Link to docs preview: https://73634--ocpdocs-pr.netlify.app/openshift-enterprise/latest/scalability_and_performance/cnf-numa-aware-scheduling
QE review:
- [ ] QE has approved this change.
Additional information:
/retest
🤖 Tue May 21 08:49:06 - Prow CI generated the docs preview:
https://73634--ocpdocs-pr.netlify.app/openshift-enterprise/latest/scalability_and_performance/cnf-numa-aware-scheduling.html
@shajmakh please review this update to the documentation associated with NROP
@kquinn1204 thank you for your efforts on this. Please ping me when the PR is ready for another review round.
@shajmakh hopefully good to go now. Thanks for your input.
@kquinn1204 thanks for addressing the comments. some nits and we should be good to go.
/lgtm Thanks for the valuable effort!
/lgtm
/label peer-review-needed
New changes are detected. LGTM label has been removed.
/label merge-review-needed
@kquinn1204 A few more nits. Most wouldn't have held up a merge review, but the YAML issue I pointed out needs to be fixed before merge. Also, the rogue module needs deleted if it isn't going to be used. ping when changes are made and I can merge it.
Thank you @stevsmit hopefully should be good to merge now.
@kquinn1204: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
/cherry-pick enterprise-4.14
/cherry-pick enterprise-4.15
/cherry-pick enterprise-4.16
/cherry-pick enterprise-4.12
/cherry-pick enterprise-4.13
@stevsmit: new pull request created: #76436
In response to this:
/cherry-pick enterprise-4.14
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@stevsmit: new pull request created: #76437
In response to this:
/cherry-pick enterprise-4.15
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@stevsmit: new pull request created: #76438
In response to this:
/cherry-pick enterprise-4.16
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@stevsmit: #73634 failed to apply on top of branch "enterprise-4.12":
Applying: TELCODOCS-1785 Improving NROP documentation
.git/rebase-apply/patch:52: trailing whitespace.
NUMA architecture allows a CPU with multiple memory controllers to use any available memory across CPU complexes, regardless of where the memory is located. This allows for increased flexibility at the expense of performance. A CPU processing a workload using memory that is outside its NUMA zone is slower than a workload processed in a single NUMA zone. Also, for I/O-constrained workloads, the network interface on a distant NUMA zone slows down how quickly information can reach the application. High-performance workloads, such as telecommunications workloads, cannot operate to specification under these conditions.
.git/rebase-apply/patch:96: trailing whitespace.
.Procedure
.git/rebase-apply/patch:144: trailing whitespace.
Applying performance profile or `KubeletConfig` automatically triggers rebooting of the nodes. If no reboot is triggered, you can troubleshoot the issue by looking at the labels in `KubeletConfig` that address the node group.
.git/rebase-apply/patch:173: trailing whitespace.
The NUMA Resources Operator requires a single NUMA node policy to be configured on the cluster. This can be achieved in two ways: by creating and applying a performance profile, or by configuring a KubeletConfig.
.git/rebase-apply/patch:553: trailing whitespace.
This example YAML shows a performance profile created by using the performance profile creator (PPC) tool:
warning: squelched 1 whitespace error
warning: 6 lines add whitespace errors.
Using index info to reconstruct a base tree...
A modules/cnf-about-collecting-nro-data.adoc
M modules/cnf-about-numa-aware-scheduling.adoc
M modules/cnf-configuring-node-groups-for-the-numaresourcesoperator.adoc
M modules/cnf-creating-nrop-cr.adoc
M modules/cnf-deploying-the-numa-aware-scheduler.adoc
M modules/cnf-scheduling-numa-aware-workloads.adoc
M scalability_and_performance/cnf-numa-aware-scheduling.adoc
Falling back to patching base and 3-way merge...
Auto-merging scalability_and_performance/cnf-numa-aware-scheduling.adoc
Auto-merging modules/cnf-scheduling-numa-aware-workloads.adoc
CONFLICT (content): Merge conflict in modules/cnf-scheduling-numa-aware-workloads.adoc
Auto-merging modules/cnf-deploying-the-numa-aware-scheduler.adoc
CONFLICT (content): Merge conflict in modules/cnf-deploying-the-numa-aware-scheduler.adoc
Auto-merging modules/cnf-creating-nrop-cr.adoc
CONFLICT (content): Merge conflict in modules/cnf-creating-nrop-cr.adoc
Auto-merging modules/cnf-configuring-node-groups-for-the-numaresourcesoperator.adoc
Auto-merging modules/cnf-about-numa-aware-scheduling.adoc
CONFLICT (content): Merge conflict in modules/cnf-about-numa-aware-scheduling.adoc
Auto-merging modules/cnf-about-collecting-ptp-data.adoc
CONFLICT (content): Merge conflict in modules/cnf-about-collecting-ptp-data.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 TELCODOCS-1785 Improving NROP documentation
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to this:
/cherry-pick enterprise-4.12
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@stevsmit: #73634 failed to apply on top of branch "enterprise-4.13":
Applying: TELCODOCS-1785 Improving NROP documentation
.git/rebase-apply/patch:52: trailing whitespace.
NUMA architecture allows a CPU with multiple memory controllers to use any available memory across CPU complexes, regardless of where the memory is located. This allows for increased flexibility at the expense of performance. A CPU processing a workload using memory that is outside its NUMA zone is slower than a workload processed in a single NUMA zone. Also, for I/O-constrained workloads, the network interface on a distant NUMA zone slows down how quickly information can reach the application. High-performance workloads, such as telecommunications workloads, cannot operate to specification under these conditions.
.git/rebase-apply/patch:96: trailing whitespace.
.Procedure
.git/rebase-apply/patch:144: trailing whitespace.
Applying performance profile or `KubeletConfig` automatically triggers rebooting of the nodes. If no reboot is triggered, you can troubleshoot the issue by looking at the labels in `KubeletConfig` that address the node group.
.git/rebase-apply/patch:173: trailing whitespace.
The NUMA Resources Operator requires a single NUMA node policy to be configured on the cluster. This can be achieved in two ways: by creating and applying a performance profile, or by configuring a KubeletConfig.
.git/rebase-apply/patch:553: trailing whitespace.
This example YAML shows a performance profile created by using the performance profile creator (PPC) tool:
warning: squelched 1 whitespace error
warning: 6 lines add whitespace errors.
Using index info to reconstruct a base tree...
A modules/cnf-about-collecting-nro-data.adoc
M modules/cnf-deploying-the-numa-aware-scheduler.adoc
M scalability_and_performance/cnf-numa-aware-scheduling.adoc
Falling back to patching base and 3-way merge...
Auto-merging scalability_and_performance/cnf-numa-aware-scheduling.adoc
Auto-merging modules/cnf-deploying-the-numa-aware-scheduler.adoc
CONFLICT (content): Merge conflict in modules/cnf-deploying-the-numa-aware-scheduler.adoc
Auto-merging modules/cnf-about-collecting-ptp-data.adoc
CONFLICT (content): Merge conflict in modules/cnf-about-collecting-ptp-data.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 TELCODOCS-1785 Improving NROP documentation
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to this:
/cherry-pick enterprise-4.13
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.