openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

OCPBUGS-27393#CloudFront update

Open brendan-daly-red-hat opened this issue 1 year ago • 7 comments

Versions: 4.12+

Issue: https://issues.redhat.com/browse/OCPBUGS-27393

Link to docs preview: https://73568--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/install_config/configuring-firewall#configuring-firewall_configuring-firewall

Update: added new text to AWS section of table in step 4.

QE review:

  • [ ] QE has approved this change.

Additional information:

brendan-daly-red-hat avatar Mar 21 '24 17:03 brendan-daly-red-hat

@brendan-daly-red-hat: This pull request references Jira Issue OCPBUGS-27393, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 21 '24 17:03 openshift-ci-robot

@brendan-daly-red-hat: No Jira issue is referenced in the title of this pull request. To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 21 '24 17:03 openshift-ci-robot

🤖 Wed Apr 10 10:39:48 - Prow CI generated the docs preview:

https://73568--ocpdocs-pr.netlify.app/ https://73568--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/install_config/configuring-firewall.html

ocpdocs-previewbot avatar Mar 21 '24 17:03 ocpdocs-previewbot

PTAL@bscott-rh

brendan-daly-red-hat avatar Mar 21 '24 17:03 brendan-daly-red-hat

/label peer-review-needed

brendan-daly-red-hat avatar Mar 21 '24 17:03 brendan-daly-red-hat

PTAL@amulmule

brendan-daly-red-hat avatar Mar 21 '24 17:03 brendan-daly-red-hat

@sjhala-ccs, Hi Shikha, I changed this reference to an xref. Can you take a look? Thanks.

brendan-daly-red-hat avatar Mar 27 '24 13:03 brendan-daly-red-hat

@jianping-shu I can make that change. So that I understand correctly, do you want me to remove the text ‘ If you use AWS Security Token Service (STS) and the private S3 bucket, you must provide access to CloudFront.’ from the table in step 4 and instead add this text to the table in step 5? URL: *.cloudfront.net Port: 443 Function: Required to use AWS Security Token Service (STS) with the private S3 bucket. If not, can you specify the step number for the table that needs to be updated?

brendan-daly-red-hat avatar Apr 02 '24 08:04 brendan-daly-red-hat

Yes. In my understanding, it shall be put into one new row of Cloud=AWS in step 4 (similar like the row of tagging.<aws_region>.amazonaws.com)

jianping-shu avatar Apr 02 '24 08:04 jianping-shu

@jianping-shu, Thanks for your reply. I added a new row for *.cloudfront.net in the 'Cloud=AWS' section of the table in step 4. Can you take a look?

brendan-daly-red-hat avatar Apr 03 '24 10:04 brendan-daly-red-hat

lgtm

jianping-shu avatar Apr 07 '24 06:04 jianping-shu

/lgtm

yunjiang29 avatar Apr 08 '24 05:04 yunjiang29

New changes are detected. LGTM label has been removed.

openshift-ci[bot] avatar Apr 08 '24 07:04 openshift-ci[bot]

/label merge-review-needed

brendan-daly-red-hat avatar Apr 08 '24 07:04 brendan-daly-red-hat

/label merge-review-needed

brendan-daly-red-hat avatar Apr 09 '24 09:04 brendan-daly-red-hat

@brendan-daly-red-hat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Apr 10 '24 10:04 openshift-ci[bot]

@abrennan89, Hi Ashleigh, I applied the required change and your suggestion, thanks.

brendan-daly-red-hat avatar Apr 10 '24 10:04 brendan-daly-red-hat

/label merge-review-needed

brendan-daly-red-hat avatar Apr 10 '24 10:04 brendan-daly-red-hat

/cherrypick enterprise-4.12

abrennan89 avatar Apr 10 '24 16:04 abrennan89

/cherrypick enterprise-4.13

abrennan89 avatar Apr 10 '24 16:04 abrennan89

/cherrypick enterprise-4.14

abrennan89 avatar Apr 10 '24 16:04 abrennan89

/cherrypick enterprise-4.15

abrennan89 avatar Apr 10 '24 16:04 abrennan89

/cherrypick enterprise-4.16

abrennan89 avatar Apr 10 '24 16:04 abrennan89

@abrennan89: #73568 failed to apply on top of branch "enterprise-4.12":

Applying: OCPBUGS-27393:CloudFront update
Using index info to reconstruct a base tree...
M	modules/configuring-firewall.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/configuring-firewall.adoc
CONFLICT (content): Merge conflict in modules/configuring-firewall.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-27393:CloudFront update
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89: new pull request created: #74473

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89: new pull request created: #74474

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89: new pull request created: #74475

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89: new pull request created: #74476

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

I closed the PRs 74477 and 74595 as this Jira update doesn't apply to 4.12. I created those CPs in error. I confirmed with the SME that the change applies to 4.14+.

brendan-daly-red-hat avatar Apr 15 '24 08:04 brendan-daly-red-hat