OCPBUGS-27393#CloudFront update
Versions: 4.12+
Issue: https://issues.redhat.com/browse/OCPBUGS-27393
Link to docs preview: https://73568--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/install_config/configuring-firewall#configuring-firewall_configuring-firewall
Update: added new text to AWS section of table in step 4.
QE review:
- [ ] QE has approved this change.
Additional information:
@brendan-daly-red-hat: This pull request references Jira Issue OCPBUGS-27393, which is invalid:
- expected the bug to target the "4.16.0" version, but no target version was set
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
Version(s):
Issue:
Link to docs preview:
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@brendan-daly-red-hat: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.
In response to this:
Version(s):
Issue:
Link to docs preview:
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
🤖 Wed Apr 10 10:39:48 - Prow CI generated the docs preview:
https://73568--ocpdocs-pr.netlify.app/ https://73568--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/install_config/configuring-firewall.html
PTAL@bscott-rh
/label peer-review-needed
PTAL@amulmule
@sjhala-ccs, Hi Shikha, I changed this reference to an xref. Can you take a look? Thanks.
@jianping-shu I can make that change. So that I understand correctly, do you want me to remove the text ‘ If you use AWS Security Token Service (STS) and the private S3 bucket, you must provide access to CloudFront.’ from the table in step 4 and instead add this text to the table in step 5? URL: *.cloudfront.net Port: 443 Function: Required to use AWS Security Token Service (STS) with the private S3 bucket. If not, can you specify the step number for the table that needs to be updated?
Yes. In my understanding, it shall be put into one new row of Cloud=AWS in step 4 (similar like the row of tagging.<aws_region>.amazonaws.com)
@jianping-shu, Thanks for your reply. I added a new row for *.cloudfront.net in the 'Cloud=AWS' section of the table in step 4. Can you take a look?
lgtm
/lgtm
New changes are detected. LGTM label has been removed.
/label merge-review-needed
/label merge-review-needed
@brendan-daly-red-hat: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@abrennan89, Hi Ashleigh, I applied the required change and your suggestion, thanks.
/label merge-review-needed
/cherrypick enterprise-4.12
/cherrypick enterprise-4.13
/cherrypick enterprise-4.14
/cherrypick enterprise-4.15
/cherrypick enterprise-4.16
@abrennan89: #73568 failed to apply on top of branch "enterprise-4.12":
Applying: OCPBUGS-27393:CloudFront update
Using index info to reconstruct a base tree...
M modules/configuring-firewall.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/configuring-firewall.adoc
CONFLICT (content): Merge conflict in modules/configuring-firewall.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-27393:CloudFront update
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to this:
/cherrypick enterprise-4.12
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@abrennan89: new pull request created: #74473
In response to this:
/cherrypick enterprise-4.13
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@abrennan89: new pull request created: #74474
In response to this:
/cherrypick enterprise-4.14
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@abrennan89: new pull request created: #74475
In response to this:
/cherrypick enterprise-4.15
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@abrennan89: new pull request created: #74476
In response to this:
/cherrypick enterprise-4.16
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.