openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

OCPBUGS-22263#updating clarifying steps

Open brendan-daly-red-hat opened this issue 1 year ago • 7 comments

Versions: 4.12+

Issue: https://issues.redhat.com/browse/OCPBUGS-22263

Link to docs preview: https://73517--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/validating-an-installation#reviewing-cluster-status-from-the-openshift-cluster-manager_validating-an-installation

Updated the 'Prerequisites' and first two steps of 'Procedure'.

QE review:

  • [ ] QE has approved this change.

Additional information:

brendan-daly-red-hat avatar Mar 21 '24 11:03 brendan-daly-red-hat

@brendan-daly-red-hat: This pull request references Jira Issue OCPBUGS-22263, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 21 '24 11:03 openshift-ci-robot

@brendan-daly-red-hat: No Jira issue is referenced in the title of this pull request. To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Version(s): 4.12-4.15

Issue:

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 21 '24 11:03 openshift-ci-robot

🤖 Thu Apr 04 08:42:26 - Prow CI generated the docs preview:

https://73517--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/validating-an-installation.html

ocpdocs-previewbot avatar Mar 21 '24 11:03 ocpdocs-previewbot

PTAL@bscott-rh

brendan-daly-red-hat avatar Mar 21 '24 11:03 brendan-daly-red-hat

/label peer-review-needed

brendan-daly-red-hat avatar Mar 21 '24 11:03 brendan-daly-red-hat

LGTM.

This PR changes technical content, so just a reminder that it still needs QE approval before it can be merged.

bburt-rh avatar Mar 21 '24 18:03 bburt-rh

Hi @brendan-daly-red-hat ,

Looks much better, thanks! Just a few small things to fix, to line up with the OpenShift Cluster Manager UI and also how we talk about it. I'll add a screenshot to the Jira for your reference.

Cheers, Dayle

dayleparker avatar Apr 03 '24 11:04 dayleparker

Screenshot 2024-04-03 at 13 29 13 Screenshot 2024-04-03 at 13 30 31

dayleparker avatar Apr 03 '24 11:04 dayleparker

@brendan-daly-red-hat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Apr 04 '24 08:04 openshift-ci[bot]

Hi @dayleparker, Thanks for your review comments and the screenshots - I've applied those changes.

Regards, Brendan

brendan-daly-red-hat avatar Apr 04 '24 08:04 brendan-daly-red-hat

Hi @brendan-daly-red-hat - I had a look at the preview, the doc looks perfect now :) Thank you so much for your updates and great attention to detail! Cheers, Dayle

dayleparker avatar Apr 04 '24 10:04 dayleparker

@brendan-daly-red-hat Hi, Changes LGTM. Thank you.

jmekkatt avatar Apr 08 '24 06:04 jmekkatt

/lgtm

jmekkatt avatar Apr 08 '24 06:04 jmekkatt

/label merge-review-needed

brendan-daly-red-hat avatar Apr 09 '24 08:04 brendan-daly-red-hat

/cherrypick enterprise-4.12

skrthomas avatar Apr 09 '24 18:04 skrthomas

/cherrypick enterprise-4.13

skrthomas avatar Apr 09 '24 18:04 skrthomas

/cherrypick enterprise-4.14

skrthomas avatar Apr 09 '24 18:04 skrthomas

/cherrypick enterprise-4.15

skrthomas avatar Apr 09 '24 18:04 skrthomas

/cherrypick enterprise-4.16

skrthomas avatar Apr 09 '24 18:04 skrthomas

@skrthomas: new pull request created: #74421

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skrthomas: new pull request created: #74422

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skrthomas: new pull request created: #74423

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skrthomas: new pull request created: #74424

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skrthomas: new pull request created: #74425

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.