openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

ROSA CLI permissions

Open mletalie opened this issue 1 year ago • 2 comments
trafficstars

Version(s):

Issue:

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

mletalie avatar Mar 19 '24 18:03 mletalie

🤖 Tue Apr 09 14:20:24 - Prow CI generated the docs preview:

https://73430--ocpdocs-pr.netlify.app/ https://73430--ocpdocs-pr.netlify.app/openshift-rosa/latest/cli_reference/rosa_cli/rosa-cli-permission-examples.html

ocpdocs-previewbot avatar Mar 19 '24 18:03 ocpdocs-previewbot

This is a great start. My comments are mostly the same re-write over and over for each command. Make sure you run everything through Vale and check all your headings for capitalization before this goes to peer review!

Thank you, will do! Need to get Vale into my process.....starting now!

mletalie avatar Apr 01 '24 12:04 mletalie

Hello @arendej, Will you please take another look at this PR when you get a moment? In regard to this comment: https://redhat-internal.slack.com/archives/C0308P3FC7R/p1711986179302469?thread_ts=1711983449.564719&cid=C0308P3FC7R

I spoke to Sadique to get further clarity about this and his thought was: "The discussion is only about what permissions are needed for AWS access key and secret key. So there is no need to specifically mention those set of commands need a Rosa token."

Let me know if that works for you and/or you see any other changes you would like made.

mletalie avatar Apr 02 '24 11:04 mletalie

lgmt

yuwang-RH avatar Apr 09 '24 06:04 yuwang-RH

lgmt

sadiquepp avatar Apr 09 '24 06:04 sadiquepp

@mletalie: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Apr 09 '24 14:04 openshift-ci[bot]

/lgtm Thanks!

mletalie avatar Apr 09 '24 14:04 mletalie

/cherrypick enterprise-4.15

EricPonvelle avatar Apr 09 '24 14:04 EricPonvelle

/cherrypick enterprise-4.16

EricPonvelle avatar Apr 09 '24 14:04 EricPonvelle

@EricPonvelle: new pull request created: #74410

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@EricPonvelle: new pull request created: #74411

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.