openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

OBSDOCS-902: YAML block bug fix

Open max-cx opened this issue 1 year ago • 9 comments
trafficstars

Version(s):

4.16, 4.15, 4.14, 4.13, 4.12

Issue:

https://issues.redhat.com/browse/OBSDOCS-902

Link to docs preview:

https://73103--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/otel/otel-sending-traces-and-metrics-to-otel-collector#sending-traces-and-metrics-to-otel-collector-without-sidecar_otel-sending-traces-and-metrics-to-otel-collector

QE review:

  • [x] QE has approved this change. See QE's comment below: https://github.com/openshift/openshift-docs/pull/73103#issuecomment-1996504232

Additional information:

max-cx avatar Mar 13 '24 16:03 max-cx

@max-cx: This pull request references OBSDOCS-902 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 13 '24 16:03 openshift-ci-robot

🤖 Fri Mar 22 20:34:37 - Prow CI generated the docs preview: https://73103--ocpdocs-pr.netlify.app

ocpdocs-previewbot avatar Mar 13 '24 16:03 ocpdocs-previewbot

@max-cx In the step 3 in https://docs.openshift.com/container-platform/4.12/otel/otel-sending-traces-and-metrics-to-otel-collector.html#sending-traces-and-metrics-to-otel-collector-without-sidecar_otel-sending-traces-and-metrics-to-otel-collector The serviceaccount name in the subjects must be otel-collector-deployment like below.

apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
  name: otel-collector
subjects:
- kind: ServiceAccount
  name: otel-collector-deployment
  namespace: observability
roleRef:
  kind: ClusterRole
  name: otel-collector
  apiGroup: rbac.authorization.k8s.io

IshwarKanse avatar Mar 14 '24 05:03 IshwarKanse

@max-cx: This pull request references OBSDOCS-902 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):

4.16, 4.15, 4.14, 4.13, 4.12

Issue:

https://issues.redhat.com/browse/OBSDOCS-902

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 22 '24 20:03 openshift-ci-robot

@max-cx: This pull request references OBSDOCS-902 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):

4.16, 4.15, 4.14, 4.13, 4.12

Issue:

https://issues.redhat.com/browse/OBSDOCS-902

Link to docs preview:

https://73103--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/otel/otel-sending-traces-and-metrics-to-otel-collector#sending-traces-and-metrics-to-otel-collector-without-sidecar_otel-sending-traces-and-metrics-to-otel-collector

QE review:

  • [x] QE has approved this change. See QE's comment below: https://github.com/openshift/openshift-docs/pull/73103#issuecomment-1996504232

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 22 '24 20:03 openshift-ci-robot

/label peer-review-needed

max-cx avatar Mar 22 '24 20:03 max-cx

LGTM!

/remove-label peer-review-in-progress /remove-label peer-review-needed /label peer-review-done

agantony avatar Mar 25 '24 06:03 agantony

@agantony: Those labels are not set on the issue: peer-review-in-progress

In response to this:

LGTM!

/remove-label peer-review-in-progress /remove-label peer-review-needed /label peer-review-done

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Mar 25 '24 06:03 openshift-ci[bot]

/label peer-review-needed

max-cx avatar Mar 27 '24 15:03 max-cx

/label merge-review-needed

max-cx avatar Apr 11 '24 20:04 max-cx

@max-cx: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Apr 12 '24 13:04 openshift-ci[bot]

/cherrypick enterprise-4.16

jeana-redhat avatar Apr 12 '24 13:04 jeana-redhat

/cherrypick enterprise-4.15

jeana-redhat avatar Apr 12 '24 13:04 jeana-redhat

/cherrypick enterprise-4.14

jeana-redhat avatar Apr 12 '24 13:04 jeana-redhat

/cherrypick enterprise-4.13

jeana-redhat avatar Apr 12 '24 13:04 jeana-redhat

/cherrypick enterprise-4.12

jeana-redhat avatar Apr 12 '24 13:04 jeana-redhat

@jeana-redhat: Those labels are not set on the issue: merge-review-in-progress, merge-review-needed

In response to this:

easy-breezy, LGTM :D

/remove-label merge-review-in-progress /remove-label merge-review-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Apr 12 '24 13:04 openshift-ci[bot]

@jeana-redhat: new pull request created: #74586

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jeana-redhat: new pull request created: #74587

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jeana-redhat: new pull request created: #74588

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jeana-redhat: new pull request created: #74589

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jeana-redhat: new pull request created: #74590

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.