openshift-docs
openshift-docs copied to clipboard
openshift
OSDOCS 9804: Removed tech preview for the user defined labels and tags for GCP and added a note
Version(s): 4.16
Issue: OSDOCS-9804
Link to docs preview: Preview
SME review:
- [x] SME has approved this change.
Additional information:
🤖 Thu May 16 07:13:38 - Prow CI generated the docs preview:
https://73001--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_gcp/installing-gcp-customizations.html
Sorry, input was not clear and caused this, but points at lines 63, 64, 65 are required. Otherwise lgtm.
Regarding the title, I did change the commit message but forgot to change the title, let me change the title too. And regarding the fix versions, when the jira was created, the feature was indeed planned for GA in 4.16 but due to some issues, it was planned for 4.17. So this PR addresses the minor updates for 4.16.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@subhtk: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
The PR title says "Removed tech preview" but I see the following still in the file:
:FeatureName: Support for user-defined labels and tags for GCP include::snippets/technology-preview.adoc[]Should that be removed? And will there be a separate PR to similarly update the 4.16 release notes?
Also, I see the linked Jira tickets reference OCP 4.17 (
Fix version/s: openshift-4.17) but this PR is targeting theenterprise-4.16branch. Two thoughts:1. Are those Jiras actually for 4.16 instead? If so, it seems like this PR should target `main` and then get cherrypicked to `enterprise-4.16`. 2. If the Jiras are truly not relevant until 4.17, then maybe this PR should just target `main` and you have a follow-up task later to cherry-pick it to the future `enterprise-4.17` branch (that isn't created yet and we also don't have a GH label for yet)? Or maybe just leave it unmerged for now and pick it back up after the 4.17 branch has been created.
Since the jira issue is about GA and the PR was initially created to track the change, but since the affected version is 4.17, and the changes are irrelevant to tech preview. I have created another jira ticket https://issues.redhat.com/browse/OSDOCS-10594 to track the changes and here is the new PR- https://github.com/openshift/openshift-docs/pull/76141. Sorry for the confusion.
@subhtk: The label(s) /label remove-merge-review-needed cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, cloud-experts, cnv, dev-tools, distributed-tracing, ims, jira/valid-bug, merge-review-in-progress, merge-review-needed, mtc, multi-arch, oadp, peer-review-done, peer-review-in-progress, peer-review-needed, rhacs, rhv, sd-docs, serverless, service-mesh, sme-review-done, sme-review-needed, staff-eng-approved, telco. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?
In response to this:
/label remove-merge-review-needed
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Due to the version change, I have created a new PR-https://github.com/openshift/openshift-docs/pull/76141, and will be closing this one.