openshift-docs
openshift-docs copied to clipboard
OADP-3399: Reworking OpenShift KubeVirt OADP docs
JIRA
-
-
Adding KubeVirt to DPA and including Virt docs into OADP docs.
-
Fixed the broken ifdef statement on 1.3 DPA for ODF
-
-
To do :
- Check the other parts of the Virt docs for what we should bring over to OADP
Link to docs preview:
QE review:
- [ ] QE has approved this change.
Additional information:
@anarnold97: This pull request references OADP-3399 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.
In response to this:
Version(s):
Issue:
Link to docs preview:
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
🤖 Fri Apr 19 20:36:25 - Prow CI generated the docs preview: https://72372--ocpdocs-pr.netlify.app Complete list of updated preview URLs: artifacts/updated_preview_urls.txt
@anarnold97: This pull request references OADP-3399 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.
In response to this:
JIRA
Link to docs preview:
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/retest
/label oadp
@anarnold97: This pull request references OADP-3399 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.
In response to this:
JIRA
Adding KubeVirt to DPA and including Virt docs into OADP docs.
Fixed the broken ifdef statement on 1.3 DPA for ODF
To do :
- Check the other parts of the Virt docs for what we should bring over to OADP
Link to docs preview:
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@anarnold97: This pull request references OADP-3399 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.
In response to this:
JIRA
Adding KubeVirt to DPA and including Virt docs into OADP docs.
Fixed the broken ifdef statement on 1.3 DPA for ODF
To do :
- Check the other parts of the Virt docs for what we should bring over to OADP
Link to docs preview:
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/label oadp
/test validate-asciidoc
@anarnold97: This pull request references OADP-3399 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.
In response to this:
JIRA
Adding KubeVirt to DPA and including Virt docs into OADP docs.
Fixed the broken ifdef statement on 1.3 DPA for ODF
To do :
- Check the other parts of the Virt docs for what we should bring over to OADP
Link to docs preview:
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@amastbau - have made your suggested changes.
In modules/oadp-kubevirt-setting-resource-limits-and-requests.adoc the values are coming from the Virt docs I will speak to Tzahi and Mordecchai and ask for their opinion, but might need to make the changes post-GA
@amastbau && @weshayutin - updated. removed the modules as agreed
/LGTM
@amastbau - thanks very much. I won't look for you
/label peer-review-needed
New changes are detected. LGTM label has been removed.
@anarnold97: This pull request references OADP-3399 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.
In response to this:
JIRA
Adding KubeVirt to DPA and including Virt docs into OADP docs.
Fixed the broken ifdef statement on 1.3 DPA for ODF
To do :
- Check the other parts of the Virt docs for what we should bring over to OADP
GA - 16th April
Link to docs preview:
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/label merge-review-needed
/remove-label merge-review-needed
/label merge-review-needed
@anarnold97 This doesn't quite look ready for merge.
- Please squash the commits.
- Which versions does this apply to?
@anarnold97: This pull request references OADP-3399 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.
In response to this:
JIRA
Adding KubeVirt to DPA and including Virt docs into OADP docs.
Fixed the broken ifdef statement on 1.3 DPA for ODF
To do :
- Check the other parts of the Virt docs for what we should bring over to OADP
GA - 16th April
Versions
- OCP 4.13 → branch/enterprise-4.13
- OCP 4.14 → branch/enterprise-4.14
- OCP 4.15 → branch/enterprise-4.15
- OCP 4.16 → branch/enterprise-4.16
Link to docs preview:
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Apologies, updated versions and squashed
/label merge-review-needed
I have another PR I will be working on post-GA and can include updates to that. See OADP-3617
@anarnold97 I'm going to hold merge due to this comment and this comment being unresolved. These are modular docs and contributing to openshift docs requirements, and this PR can't be merged until the comments are resolved.
Corrected and updated to include a new level 2 header
/label merge-review-needed
/remove-label merge-review-needed
/remove-label peer-review-done
@anarnold97: This pull request references OADP-3399 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.
In response to this:
JIRA
Adding KubeVirt to DPA and including Virt docs into OADP docs.
Fixed the broken ifdef statement on 1.3 DPA for ODF
To do :
- Check the other parts of the Virt docs for what we should bring over to OADP
GA - 16th April
Versions
- OCP 4.13 → branch/enterprise-4.13
- OCP 4.14 → branch/enterprise-4.14
- OCP 4.15 → branch/enterprise-4.15
- OCP 4.16 → branch/enterprise-4.16
Link to docs preview:
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
- Moved procedure to module
- Moved
xrefsto.Additional resources - Added level 2 heading... if you have a better name for this, then all ears
/label peer-review-needed