openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

OADP-3399: Reworking OpenShift KubeVirt OADP docs

Open anarnold97 opened this issue 1 year ago • 9 comments

JIRA

  • OADP-3399

    • Adding KubeVirt to DPA and including Virt docs into OADP docs.

    • Fixed the broken ifdef statement on 1.3 DPA for ODF

  • To do :

    • Check the other parts of the Virt docs for what we should bring over to OADP

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

anarnold97 avatar Feb 29 '24 14:02 anarnold97

@anarnold97: This pull request references OADP-3399 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Feb 29 '24 14:02 openshift-ci-robot

🤖 Fri Apr 19 20:36:25 - Prow CI generated the docs preview: https://72372--ocpdocs-pr.netlify.app Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

ocpdocs-previewbot avatar Feb 29 '24 14:02 ocpdocs-previewbot

@anarnold97: This pull request references OADP-3399 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

JIRA

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Feb 29 '24 18:02 openshift-ci-robot

/retest

anarnold97 avatar Feb 29 '24 20:02 anarnold97

/label oadp

anarnold97 avatar Mar 01 '24 02:03 anarnold97

@anarnold97: This pull request references OADP-3399 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

JIRA

  • OADP-3399

    • Adding KubeVirt to DPA and including Virt docs into OADP docs.

    • Fixed the broken ifdef statement on 1.3 DPA for ODF

  • To do :

    • Check the other parts of the Virt docs for what we should bring over to OADP

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 01 '24 03:03 openshift-ci-robot

@anarnold97: This pull request references OADP-3399 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

JIRA

  • OADP-3399

    • Adding KubeVirt to DPA and including Virt docs into OADP docs.

    • Fixed the broken ifdef statement on 1.3 DPA for ODF

  • To do :

    • Check the other parts of the Virt docs for what we should bring over to OADP

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 01 '24 03:03 openshift-ci-robot

/label oadp

anarnold97 avatar Mar 05 '24 20:03 anarnold97

/test validate-asciidoc

anarnold97 avatar Mar 26 '24 14:03 anarnold97

@anarnold97: This pull request references OADP-3399 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

JIRA

  • OADP-3399

    • Adding KubeVirt to DPA and including Virt docs into OADP docs.

    • Fixed the broken ifdef statement on 1.3 DPA for ODF

  • To do :

    • Check the other parts of the Virt docs for what we should bring over to OADP

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 26 '24 15:03 openshift-ci-robot

@amastbau - have made your suggested changes.

In modules/oadp-kubevirt-setting-resource-limits-and-requests.adoc the values are coming from the Virt docs I will speak to Tzahi and Mordecchai and ask for their opinion, but might need to make the changes post-GA

anarnold97 avatar Apr 12 '24 16:04 anarnold97

@amastbau && @weshayutin - updated. removed the modules as agreed

anarnold97 avatar Apr 15 '24 15:04 anarnold97

/LGTM

amastbau avatar Apr 16 '24 10:04 amastbau

@amastbau - thanks very much. I won't look for you

anarnold97 avatar Apr 16 '24 10:04 anarnold97

/label peer-review-needed

anarnold97 avatar Apr 16 '24 10:04 anarnold97

New changes are detected. LGTM label has been removed.

openshift-ci[bot] avatar Apr 16 '24 19:04 openshift-ci[bot]

@anarnold97: This pull request references OADP-3399 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

JIRA

  • OADP-3399

    • Adding KubeVirt to DPA and including Virt docs into OADP docs.

    • Fixed the broken ifdef statement on 1.3 DPA for ODF

  • To do :

    • Check the other parts of the Virt docs for what we should bring over to OADP

GA - 16th April

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Apr 16 '24 21:04 openshift-ci-robot

/label merge-review-needed

anarnold97 avatar Apr 16 '24 21:04 anarnold97

/remove-label merge-review-needed

anarnold97 avatar Apr 16 '24 22:04 anarnold97

/label merge-review-needed

anarnold97 avatar Apr 16 '24 22:04 anarnold97

@anarnold97 This doesn't quite look ready for merge.

  1. Please squash the commits.
  2. Which versions does this apply to?

sheriff-rh avatar Apr 17 '24 12:04 sheriff-rh

@anarnold97: This pull request references OADP-3399 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

JIRA

  • OADP-3399

    • Adding KubeVirt to DPA and including Virt docs into OADP docs.

    • Fixed the broken ifdef statement on 1.3 DPA for ODF

  • To do :

    • Check the other parts of the Virt docs for what we should bring over to OADP

GA - 16th April

Versions

  • OCP 4.13 → branch/enterprise-4.13
  • OCP 4.14 → branch/enterprise-4.14
  • OCP 4.15 → branch/enterprise-4.15
  • OCP 4.16 → branch/enterprise-4.16

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Apr 17 '24 13:04 openshift-ci-robot

Apologies, updated versions and squashed

anarnold97 avatar Apr 17 '24 13:04 anarnold97

/label merge-review-needed

I have another PR I will be working on post-GA and can include updates to that. See OADP-3617

anarnold97 avatar Apr 17 '24 17:04 anarnold97

@anarnold97 I'm going to hold merge due to this comment and this comment being unresolved. These are modular docs and contributing to openshift docs requirements, and this PR can't be merged until the comments are resolved.

skrthomas avatar Apr 17 '24 19:04 skrthomas

Corrected and updated to include a new level 2 header

/label merge-review-needed

anarnold97 avatar Apr 17 '24 21:04 anarnold97

/remove-label merge-review-needed

ShaunaDiaz avatar Apr 18 '24 18:04 ShaunaDiaz

/remove-label peer-review-done

anarnold97 avatar Apr 18 '24 21:04 anarnold97

@anarnold97: This pull request references OADP-3399 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

JIRA

  • OADP-3399

    • Adding KubeVirt to DPA and including Virt docs into OADP docs.

    • Fixed the broken ifdef statement on 1.3 DPA for ODF

  • To do :

    • Check the other parts of the Virt docs for what we should bring over to OADP

GA - 16th April

Versions

  • OCP 4.13 → branch/enterprise-4.13
  • OCP 4.14 → branch/enterprise-4.14
  • OCP 4.15 → branch/enterprise-4.15
  • OCP 4.16 → branch/enterprise-4.16

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Apr 19 '24 00:04 openshift-ci-robot

  • Moved procedure to module
  • Moved xrefs to .Additional resources
  • Added level 2 heading... if you have a better name for this, then all ears

/label peer-review-needed

anarnold97 avatar Apr 19 '24 00:04 anarnold97