openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

OCPBUGS-30076: Fixed minor bugs with OCI docs post 4.15

Open dfitzmau opened this issue 1 year ago • 8 comments
trafficstars

Version(s): 4.14-4.16

Issue: OCPBUGS-30076 OCPBUGS-30322

Link to docs preview:

  • [ ] SME has approved this change.
  • [ ] QE has approved this change.

Additional information: Google doc BHE - AI Google doc BHE - ABI AI screenshots

dfitzmau avatar Feb 29 '24 09:02 dfitzmau

@dfitzmau: This pull request references Jira Issue OCPBUGS-30076, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Feb 29 '24 09:02 openshift-ci-robot

🤖 Tue Apr 16 10:39:39 - Prow CI generated the docs preview: https://72364--ocpdocs-pr.netlify.app Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

ocpdocs-previewbot avatar Feb 29 '24 09:02 ocpdocs-previewbot

@dfitzmau: No Jira issue is referenced in the title of this pull request. To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Version(s): 4.15 and 4.16

Issue: OCPBUGS-30076

Link to docs preview:

  • [ ] SME has approved this change.
  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 04 '24 15:03 openshift-ci-robot

Please update the PR title to OCPBUGS-30076 and run /jira refresh

pawanpinjarkar avatar Mar 04 '24 17:03 pawanpinjarkar

@dfitzmau: This pull request references Jira Issue OCPBUGS-30076, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Version(s): 4.14-4.16

Issue: OCPBUGS-30076

Link to docs preview:

  • [ ] SME has approved this change.
  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 05 '24 11:03 openshift-ci-robot

/jira refresh

dfitzmau avatar Mar 05 '24 11:03 dfitzmau

@dfitzmau: This pull request references Jira Issue OCPBUGS-30076, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 05 '24 11:03 openshift-ci-robot

/lgtm

adriengentil avatar Mar 28 '24 13:03 adriengentil

/lgtm

yobshans avatar Apr 03 '24 22:04 yobshans

@yobshans: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Apr 03 '24 22:04 openshift-ci[bot]

/lgtm

mhanss avatar Apr 04 '24 08:04 mhanss

/label peer-review-needed

dfitzmau avatar Apr 09 '24 08:04 dfitzmau

New changes are detected. LGTM label has been removed.

openshift-ci[bot] avatar Apr 10 '24 10:04 openshift-ci[bot]

/retest

dfitzmau avatar Apr 10 '24 16:04 dfitzmau

/retest

dfitzmau avatar Apr 11 '24 08:04 dfitzmau

/label merge-review-needed

dfitzmau avatar Apr 11 '24 11:04 dfitzmau

Merger: please let me know when I should notify the team of the doc submission as it changes the topic map so rebase operations are required. Rebase operations should always be done but good to give a notification.

dfitzmau avatar Apr 11 '24 11:04 dfitzmau

@dfitzmau: This pull request references Jira Issue OCPBUGS-30076, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Version(s): 4.14-4.16

Issue: OCPBUGS-30076 OCPBUGS-30322

Link to docs preview:

  • [x] SME has approved this change.
  • [x] QE has approved this change.

Additional information: Google doc customer feedback - AI Google doc customer feedback - ABI AI screenshots Diagram ideas Add diagram here also

Considerations:

  • For the term "CSI", would Oracle refer to the term as the Oracle CSI for File or Oracle CSI for File Storage?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Apr 15 '24 14:04 openshift-ci-robot

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Apr 16 '24 10:04 openshift-ci[bot]

/label merge-review-needed

dfitzmau avatar Apr 16 '24 13:04 dfitzmau

@dfitzmau, PR mentions 4.14+, but the labels are 4.15 and 4.16. Can you confirm if this also belongs in 4.14? Thanks!

jab-rh avatar Apr 16 '24 17:04 jab-rh

@dfitzmau: Jira Issue OCPBUGS-30076 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

In response to this:

Version(s): 4.14-4.16

Issue: OCPBUGS-30076 OCPBUGS-30322

Link to docs preview:

  • [x] SME has approved this change.
  • [x] QE has approved this change.

Additional information: Google doc customer feedback - AI Google doc customer feedback - ABI AI screenshots Diagram ideas Add diagram here also

Considerations:

  • For the term "CSI", would Oracle refer to the term as the Oracle CSI for File or Oracle CSI for File Storage?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Apr 16 '24 17:04 openshift-ci-robot

/cherry-pick enterprise-4.16

jab-rh avatar Apr 16 '24 17:04 jab-rh

/cherry-pick enterprise-4.15

jab-rh avatar Apr 16 '24 17:04 jab-rh

@jab-rh: #72364 failed to apply on top of branch "enterprise-4.16":

Applying: OCPBUGS-30076: Fixed minor bugs with OCI docs post 4.15
Using index info to reconstruct a base tree...
M	_attributes/common-attributes.adoc
M	_topic_maps/_topic_map.yml
M	contributing_to_docs/term_glossary.adoc
M	welcome/index.adoc
Falling back to patching base and 3-way merge...
Auto-merging welcome/index.adoc
Removing modules/verifying-cluster-install-oci.adoc
Auto-merging contributing_to_docs/term_glossary.adoc
CONFLICT (content): Merge conflict in contributing_to_docs/term_glossary.adoc
Auto-merging _topic_maps/_topic_map.yml
Auto-merging _attributes/common-attributes.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-30076: Fixed minor bugs with OCI docs post 4.15
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jab-rh: #72364 failed to apply on top of branch "enterprise-4.15":

Applying: OCPBUGS-30076: Fixed minor bugs with OCI docs post 4.15
Using index info to reconstruct a base tree...
M	_attributes/common-attributes.adoc
M	_topic_maps/_topic_map.yml
M	contributing_to_docs/term_glossary.adoc
Falling back to patching base and 3-way merge...
Removing modules/verifying-cluster-install-oci.adoc
Auto-merging contributing_to_docs/term_glossary.adoc
CONFLICT (content): Merge conflict in contributing_to_docs/term_glossary.adoc
Auto-merging _topic_maps/_topic_map.yml
Auto-merging _attributes/common-attributes.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-30076: Fixed minor bugs with OCI docs post 4.15
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dfitzmau, looks like these don't merge cleanly; it should merge cleanly into 4.16 though.

@bergerhoffer, I wonder if this needs a revert?

jab-rh avatar Apr 16 '24 17:04 jab-rh

@dfitzmau, looks like these don't merge cleanly; it should merge cleanly into 4.16 though.

@bergerhoffer, I wonder if this needs a revert?

I think it's OK. The difference is among the term_glossary file entries where I ddi modify this file as part of this PR (PM request).

Screenshot from 2024-04-17 09-40-46

dfitzmau avatar Apr 17 '24 08:04 dfitzmau