openshift-docs
openshift-docs copied to clipboard
Virtualization docs fixes during ROSA review
Fixing various errors in the Applications docs as I find them during the ROSA content port. Mostly formatting, wording, and such.
Previews:
Installing VirtIO drivers from a container disk added as a SATA CD drive -- Added -n namespace to command.
Adding a key when creating a VM by using the command line and Enabling dynamic key injection by using the command line -- Added namespace to code example in step 3 to match namespace in step 1 code block.
Adding a virtual machine to a service mesh -- Fixed YAML spacing in the code example in step 3.
Adding a vTPM device to a virtual machine -- Added -n namespace to command in step 1.
Configuring a storage class for custom boot source updates -- Added required parameters to code example. [ ] QE has approved this change. Fixed spacing in code block in step 3a.
Connecting to a VM attached to a secondary network by using SSH -- Added -n namespace to command.
Creating a Linux bridge NAD by using the command line -- Added required quotes to values. [ ] QE has approved this change.
Creating a service by using the command line -- Added required parameters to step 3. [ ] QE has approved this change.
Creating a VM from a VirtualMachine manifest -- Added -n <namespace> to code example in step 3
Creating a VM from a container disk by using the web console -- Corrected the web console steps.
Customizing the storage profile -- Fixed punctuation in step 1.
Disabling TLS for a container registry -- Added example of how to edit the file in Step 1.
Editing a boot order list in the YAML configuration file -- Added -n namespace to command.
Editing a virtual machine by using the command line -- Added -n namespace to command.
Enabling dynamic SSH key injection by using the web console -- Updated procedure step 3 to match what is in console.
Enabling preallocation for a data volume -- Added required parameters to code block. [ ] QE has approved this change.
Hot plugging a bridge network interface using the CLI -- Added -n namespace to command in step 1.
Initiating live migration by using the command line -- Added -n namespace to command.
Pause a virtual machine -- New file copied from virt-starting-vm-web.adoc and changed start to pause.
Initiating live migration by using the command line -- Added -n namespace to command in verification.
PXE booting with a specified MAC address -- Added verification heading.
Restarting a virtual machine -- Updated substeps under step 3 to match web console.
Starting a virtual machine -- Updated substeps under step 3 to match web console.
Stopping a virtual machine -- Updated substeps under step 3 to match web console.
Unpausing a virtual machine -- Updated substeps under step 3 to match web console.
Post-install ->Network configuration -> Demoted assembly-level next step to module level in Creating a Linux bridge NAD by using the web console and Configuring SR-IOV network devices.
Controlling virtual machine states -- Reordered modules and added new module for pausing. Current docs.
🤖 Wed Apr 10 13:31:06 - Prow CI generated the docs preview: https://69051--ocpdocs-pr.netlify.app Complete list of updated preview URLs: artifacts/updated_preview_urls.txt
The branch/enterprise-4.16 label has been added to this PR.
This is because your PR targets the main branch and is labeled for enterprise-4.15. And any PR going into main must also target the latest version branch (enterprise-4.16).
If the update in your PR does NOT apply to version 4.16 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.
@kbidarkar As part of the project to port docs content from OCP to ROSA/OSD, I performed each of the procedures in the Virtualization book. I found various places where there were changes, mistakes, etc. There are a few changes that I would feel more comfortable if QE reviewed the changes, all are indicated with QE REVIEW NEEDED. Pan suggested this is something you could help with. Please let me know if you can help. There is no hard deadline; but, I would like to merge these PRs, as they have been lingering for awhile.
@awels Are you able to look at @jpeimer comment above?
@jpeimer and @dshchedr from QE have reviewed it. Apart from the comments left by them, it LGTM. @mburke5678 FYI.
@mburke5678: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
/cherrypick enterprise-4.14
/cherrypick enterprise-4.15
/cherrypick enterprise-4.16
@mburke5678: new pull request created: #74496
In response to this:
/cherrypick enterprise-4.14
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@mburke5678: new pull request created: #74497
In response to this:
/cherrypick enterprise-4.15
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@mburke5678: new pull request created: #74498
In response to this:
/cherrypick enterprise-4.16
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.