openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

OSDOCS-4339: Added gcp to platform parameter

Open mjpytlak opened this issue 2 years ago • 3 comments

Version(s): 4.6+

Issue: This PR addresses osdocs-4339. I added gcp as a supported value of the platform parameter.

Link to docs preview: Installation configuration parameters > Required configuration parameters

mjpytlak avatar Oct 17 '22 18:10 mjpytlak

🤖 Updated build preview is available at: https://51756--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/1909

ocpdocs-previewbot avatar Oct 17 '22 18:10 ocpdocs-previewbot

@jianli-wei Ready for QE review. PTAL. Thank you.

mjpytlak avatar Oct 17 '22 18:10 mjpytlak

/remove-label peer-review-needed /label peer-review-in-progress

JoeAldinger avatar Oct 17 '22 20:10 JoeAldinger

/remove-label peer-review-in-progress /label peer-review-done /lgtm

JoeAldinger avatar Oct 18 '22 14:10 JoeAldinger

@jianli-wei Following up on this request for review. PTAL. I believe we are good to go. Thank you for pointing out the gap in the doc.

mjpytlak avatar Oct 21 '22 18:10 mjpytlak

@jianli-wei will you PTAL?

kalexand-rh avatar Oct 27 '22 17:10 kalexand-rh

Only versions 4.8+ are still in maintenance. I am removing labels from earlier versions from this PR.

kalexand-rh avatar Oct 28 '22 13:10 kalexand-rh

/label qe-approved

jianli-wei avatar Nov 02 '22 02:11 jianli-wei

/cherrypick enterprise-4.12

mjpytlak avatar Nov 02 '22 11:11 mjpytlak

/cherrypick enterprise-4.11

mjpytlak avatar Nov 02 '22 11:11 mjpytlak

/cherrypick enterprise-4.10

mjpytlak avatar Nov 02 '22 11:11 mjpytlak

/cherrypick enterprise-4.9

mjpytlak avatar Nov 02 '22 11:11 mjpytlak

/cherrypick enterprise-4.8

mjpytlak avatar Nov 02 '22 11:11 mjpytlak

@mjpytlak: new pull request created: #52398

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjpytlak: #51756 failed to apply on top of branch "enterprise-4.11":

Applying: OSDOCS-4339: Added gcp to platform parameter
Using index info to reconstruct a base tree...
M	modules/installation-configuration-parameters.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-configuration-parameters.adoc
CONFLICT (content): Merge conflict in modules/installation-configuration-parameters.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OSDOCS-4339: Added gcp to platform parameter
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjpytlak: #51756 failed to apply on top of branch "enterprise-4.10":

Applying: OSDOCS-4339: Added gcp to platform parameter
Using index info to reconstruct a base tree...
M	modules/installation-configuration-parameters.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-configuration-parameters.adoc
CONFLICT (content): Merge conflict in modules/installation-configuration-parameters.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OSDOCS-4339: Added gcp to platform parameter
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjpytlak: #51756 failed to apply on top of branch "enterprise-4.9":

Applying: OSDOCS-4339: Added gcp to platform parameter
Using index info to reconstruct a base tree...
M	modules/installation-configuration-parameters.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-configuration-parameters.adoc
CONFLICT (content): Merge conflict in modules/installation-configuration-parameters.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OSDOCS-4339: Added gcp to platform parameter
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjpytlak: #51756 failed to apply on top of branch "enterprise-4.8":

Applying: OSDOCS-4339: Added gcp to platform parameter
Using index info to reconstruct a base tree...
M	modules/installation-configuration-parameters.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-configuration-parameters.adoc
CONFLICT (content): Merge conflict in modules/installation-configuration-parameters.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OSDOCS-4339: Added gcp to platform parameter
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.