openshift-docs
openshift-docs copied to clipboard
openshift
BZ1937814: MCP transitions to UPDATING and READYMACHINECOUNT decrements on cordon
https://bugzilla.redhat.com/show_bug.cgi?id=1937814
Documenting what MCP status (oc get mcp) field signifies in product doc would avoid confusion on why MCO is reporting a given state.
For the start we can get these information from MCP API doc https://github.com/openshift/machine-config-operator/blob/master/pkg/apis/machineconfiguration.openshift.io/v1/types.go#L284-L298 .
The problem here is MCO is not updating a node, instead a user manually cordoned a node. As a result MCO updates its ReadyMachineCount to 2 and moves its status to updating. Updated machinecount is still 3 because node has desired rendered MachineConfig which means there is no pending update from MCO side. If it doesn't do that and user creates a MachineConfig, there is high chance that multiple node will be in cordon state (one that user manually did and one that MCO started) and it may cause workload disruption and other undesired state.
🤖 Updated build preview is available at: https://51545--docspreview.netlify.app
Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/2055
I agree with Trevor as well, it will be good to have MCO API comment up-to-date so that this PR can directly refer to it. I have created a MCO story to work on it https://issues.redhat.com/browse/MCO-403 . Since, this is not an urgent issue, perhaps we can wait on getting MCO-403 done and update this PR accordingly.
@sinnykumari @yuqi-zhang @rioliu-rh
This line, is _ Expect them to be hidden at some point in the future._ true?
Note that the machineconfigs listed as rendered are not meant to be changed or deleted. Expect them to be hidden at some point in the future.
@sinnykumari Do we want to merge this PR now (when it's ready, of course!), to get the info out to the users and we can edit as needed after the API comments are updated? I think I've made some good progress at improving the end user docs.
we can go with this PR as well and make any additional edits later on. No need to block this PR.
@rioliu-rh I made a number of changes based on your suggestions. Could I bother take another look?
@rioliu-rh I made a number of changes based on your suggestions. Could I bother take another look?
lgtm
@mburke5678: new pull request created: #51851
In response to this:
/cherrypick enterprise-4.12
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@mburke5678: new pull request created: #51852
In response to this:
/cherrypick enterprise-4.11
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@mburke5678: new pull request created: #51853
In response to this:
/cherrypick enterprise-4.10
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@mburke5678: new pull request created: #51854
In response to this:
/cherrypick enterprise-4.9
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@mburke5678: new pull request created: #51855
In response to this:
/cherrypick enterprise-4.8
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@mburke5678: new pull request created: #51856
In response to this:
/cherrypick enterprise-4.7
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.