openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

TELCODOCS-935 - PTP adding Intel Fortville NIC boundary_clock_jbod note for BC config

Open aireilly opened this issue 3 years ago • 4 comments

Documentation should be updated to indicate that the boundary_clock_jbod parameter should be set to 0 by default if the intent is to only deploy the service on E810 NICs or add a note that indicates that boundary_clock_jbod should only be set if the service is being deployed on a Fortville (X710) NIC. In other words, the boundary_clock_jbod parameter should be set to "0" for the Intel E810 NIC.

https://issues.redhat.com/browse/TELCODOCS-935

Version(s): enterprise-4.9+

Preview: https://51518--docspreview.netlify.app/openshift-enterprise/latest/networking/using-ptp.html#configuring-linuxptp-services-as-boundary-clock_using-ptp

aireilly avatar Oct 11 '22 16:10 aireilly

@josephdrichard PTAL. Is this only needed for boundary clock?

aireilly avatar Oct 11 '22 16:10 aireilly

🤖 Updated build preview is available at: https://51518--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/1958

ocpdocs-previewbot avatar Oct 11 '22 16:10 ocpdocs-previewbot

/lgtm

josephdrichard avatar Oct 17 '22 14:10 josephdrichard

@obochan-rh PTAL

aireilly avatar Oct 17 '22 19:10 aireilly

/lgtm

obochan-rh avatar Oct 18 '22 08:10 obochan-rh

@obochan-rh: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Oct 18 '22 08:10 openshift-ci[bot]

/label peer-review-needed /label telco

aireilly avatar Oct 18 '22 08:10 aireilly

Just an FYI your commit message doesn't match the title of your PR.

opayne1 avatar Oct 18 '22 13:10 opayne1

New changes are detected. LGTM label has been removed.

openshift-ci[bot] avatar Oct 18 '22 14:10 openshift-ci[bot]

/label merge-review-needed

aireilly avatar Oct 18 '22 14:10 aireilly

/cherry-pick enterprise-4.9

maxwelldb avatar Oct 18 '22 18:10 maxwelldb

/cherry-pick enterprise-4.10

maxwelldb avatar Oct 18 '22 18:10 maxwelldb

/cherry-pick enterprise-4.11

maxwelldb avatar Oct 18 '22 18:10 maxwelldb

/cherry-pick enterprise-4.12

maxwelldb avatar Oct 18 '22 18:10 maxwelldb

@maxwelldb: #51518 failed to apply on top of branch "enterprise-4.9":

Applying: TELCODOCS-935 - PTP adding Intel Fortville NIC boundary_clock_jbod note for BC config
Using index info to reconstruct a base tree...
M	modules/nw-ptp-configuring-linuxptp-services-as-boundary-clock.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/nw-ptp-configuring-linuxptp-services-as-boundary-clock.adoc
CONFLICT (content): Merge conflict in modules/nw-ptp-configuring-linuxptp-services-as-boundary-clock.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 TELCODOCS-935 - PTP adding Intel Fortville NIC boundary_clock_jbod note for BC config
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maxwelldb: new pull request created: #51812

In response to this:

/cherry-pick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maxwelldb: new pull request created: #51813

In response to this:

/cherry-pick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maxwelldb: new pull request created: #51814

In response to this:

/cherry-pick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aireilly Looks like a manual cherrypick is needed for 4.9.

maxwelldb avatar Oct 18 '22 18:10 maxwelldb

@aireilly Does this still need to be cherry picked to 4.9?

bergerhoffer avatar Nov 15 '22 17:11 bergerhoffer

@bergerhoffer Thanks. That's twice now you've saved my bacon on missed CPs :sweat:

aireilly avatar Nov 16 '22 10:11 aireilly