openshift-docs
openshift-docs copied to clipboard
openshift
OCPBUGS#2006: Added custom tags to example
Version(s): 4.8+
Issue: https://issues.redhat.com/browse/OCPBUGS-2006
Link to docs preview: https://51418--docspreview.netlify.app/openshift-enterprise/latest/machine_management/creating_machinesets/creating-machineset-azure.html#machineset-yaml-azure_creating-machineset-azure
QE review:
- [ ] QE has approved this change.
🤖 Updated build preview is available at: https://51418--docspreview.netlify.app
Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/3065
When I read the description for the tags I don't get the impression that as a customer I can set and modify them as I see fit, it almost reads as something that is required to be there in order for the cluster to operate rather than something optional I can use for my own resource management needs, I think we should make it more clear that customers can add additional tags/values in their machineset, maybe an example such as:
tags:
- name: company_division value: Legal
From reading the doc I just don't get the impression that this is a customer setable/usable field.
When I read the description for the tags I don't get the impression that as a customer I can set and modify them as I see fit, it almost reads as something that is required to be there in order for the cluster to operate rather than something optional I can use for my own resource management needs, I think we should make it more clear that customers can add additional tags/values in their machineset, maybe an example such as:
tags:
- name: company_division value: Legal
From reading the doc I just don't get the impression that this is a customer setable/usable field.
I too had a similar opinion while creating this PR. But this is just a clone of a really old PR that went stale https://github.com/openshift/openshift-docs/pull/21475.I did see lgtm from one of the QEs I suppose, hence thought may be this would be it. I definitely agree what you mentioned. Will incorporate those changes.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
/remove-label peer-review-in-progress /remove-label peer-review-needed /label peer-review-done
@snarayan-redhat: #51418 failed to apply on top of branch "enterprise-4.8":
Applying: Added custom tags to example
Using index info to reconstruct a base tree...
M modules/machineset-yaml-azure.adoc
A storage/container_storage_interface/persistent-storage-csi-aws-efs.adoc
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): storage/container_storage_interface/persistent-storage-csi-aws-efs.adoc deleted in HEAD and modified in Added custom tags to example. Version Added custom tags to example of storage/container_storage_interface/persistent-storage-csi-aws-efs.adoc left in tree.
Auto-merging modules/machineset-yaml-azure.adoc
CONFLICT (content): Merge conflict in modules/machineset-yaml-azure.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Added custom tags to example
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to this:
/cherrypick enterprise-4.8
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@snarayan-redhat: #51418 failed to apply on top of branch "enterprise-4.9":
Applying: Added custom tags to example
Using index info to reconstruct a base tree...
M modules/machineset-yaml-azure.adoc
M storage/container_storage_interface/persistent-storage-csi-aws-efs.adoc
Falling back to patching base and 3-way merge...
Auto-merging storage/container_storage_interface/persistent-storage-csi-aws-efs.adoc
Auto-merging modules/machineset-yaml-azure.adoc
CONFLICT (content): Merge conflict in modules/machineset-yaml-azure.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Added custom tags to example
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to this:
/cherrypick enterprise-4.9
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@snarayan-redhat: new pull request created: #52523
In response to this:
/cherrypick enterprise-4.10
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@snarayan-redhat: new pull request created: #52524
In response to this:
/cherrypick enterprise-4.11
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@snarayan-redhat: new pull request created: #52525
In response to this:
/cherrypick enterprise-4.12
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.