openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

Adds important admonition and note to disconnected installations when…

Open stevsmit opened this issue 3 years ago • 6 comments

Adds important admonition and note to disconnected installations when using oc adm catalog and oc image mirror commands

Version(s): 4.10+

Issue: https://issues.redhat.com/browse/OSDOCS-3907

Link to docs preview: https://51305--docspreview.netlify.app/openshift-enterprise/latest/installing/disconnected_install/installing-mirroring-installation-images.html#olm-mirror-catalog_installing-mirroring-installation-images

Change management acks required: Pending QE, SME, PM, DPM, Product Experience

Associated pull requests for Release Note changes and admonitions:

4.12: https://github.com/openshift/openshift-docs/pull/51308 4.11: https://github.com/openshift/openshift-docs/pull/51309 4.10: https://github.com/openshift/openshift-docs/pull/51311

stevsmit avatar Oct 05 '22 19:10 stevsmit

🤖 Updated build preview is available at: https://51305--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/3228

ocpdocs-previewbot avatar Oct 05 '22 19:10 ocpdocs-previewbot

/label peer-review-in-progress

kcarmichael08 avatar Oct 05 '22 20:10 kcarmichael08

/label peer-review-done

kcarmichael08 avatar Oct 05 '22 21:10 kcarmichael08

/remove-label peer-review-needed

kcarmichael08 avatar Oct 05 '22 21:10 kcarmichael08

/remove-label peer-review-in-progress

kcarmichael08 avatar Oct 05 '22 21:10 kcarmichael08

I approve both this change and the related release notes changes.

I think that as long as the acks mention the release notes that you can collect them all here.

kalexand-rh avatar Oct 06 '22 17:10 kalexand-rh

/lgtm

zhouying7780 avatar Oct 18 '22 02:10 zhouying7780

I think what we want here is to use the --skip-missing flag instead of the broader --continue-on-error. The latter will also continue on other errors (like missing layers in the target mirror that were expected to be there) that the user will want to know about.

dmesser avatar Oct 19 '22 16:10 dmesser

/lgtm

zhouying7780 avatar Nov 08 '22 07:11 zhouying7780

New changes are detected. LGTM label has been removed.

openshift-ci[bot] avatar Nov 08 '22 18:11 openshift-ci[bot]

Thanks for the additional preview link @stevsmit. Peer review LGTM.

mjpytlak avatar Nov 08 '22 21:11 mjpytlak

/cherrypick enterprise-4.12

mjpytlak avatar Nov 09 '22 13:11 mjpytlak

/cherrypick enterprise-4.11

mjpytlak avatar Nov 09 '22 13:11 mjpytlak

/cherrypick enterprise-4.10

mjpytlak avatar Nov 09 '22 13:11 mjpytlak

@mjpytlak: #51305 failed to apply on top of branch "enterprise-4.12":

Applying: Adds important admonition and note to disconnected installations when using oc adm catalog and oc image mirror commands
.git/rebase-apply/patch:17: trailing whitespace.
Running `oc image mirror` might result in the following error: `error: unable to retrieve source image`. This error occurs when image indexes include references to images that no longer exist on the image registry. Image indexes might retain older references to allow users running those images an upgrade path to newer points on the upgrade graph. As a temporary workaround, you can use the `--skip-missing` option to bypass the error and continue downloading the image index. For more information, see link:https://access.redhat.com/solutions/6975305[Service Mesh Operator mirroring failed]. 
.git/rebase-apply/patch:40: trailing whitespace.
* Running `oc adm catalog mirror` might result in the following error: `error: unable to retrieve source image`. This error occurs when image indexes include references to images that no longer exist on the image registry. Image indexes might retain older references to allow users running those images an upgrade path to newer points on the upgrade graph. As a temporary workaround, you can use the `--skip-missing` option to bypass the error and continue downloading the image index. For more information, see link:https://access.redhat.com/solutions/6975305[Service Mesh Operator mirroring failed]. 
warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	modules/olm-mirroring-catalog.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/olm-mirroring-catalog.adoc
CONFLICT (content): Merge conflict in modules/olm-mirroring-catalog.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Adds important admonition and note to disconnected installations when using oc adm catalog and oc image mirror commands
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjpytlak: #51305 failed to apply on top of branch "enterprise-4.11":

Applying: Adds important admonition and note to disconnected installations when using oc adm catalog and oc image mirror commands
.git/rebase-apply/patch:17: trailing whitespace.
Running `oc image mirror` might result in the following error: `error: unable to retrieve source image`. This error occurs when image indexes include references to images that no longer exist on the image registry. Image indexes might retain older references to allow users running those images an upgrade path to newer points on the upgrade graph. As a temporary workaround, you can use the `--skip-missing` option to bypass the error and continue downloading the image index. For more information, see link:https://access.redhat.com/solutions/6975305[Service Mesh Operator mirroring failed]. 
.git/rebase-apply/patch:40: trailing whitespace.
* Running `oc adm catalog mirror` might result in the following error: `error: unable to retrieve source image`. This error occurs when image indexes include references to images that no longer exist on the image registry. Image indexes might retain older references to allow users running those images an upgrade path to newer points on the upgrade graph. As a temporary workaround, you can use the `--skip-missing` option to bypass the error and continue downloading the image index. For more information, see link:https://access.redhat.com/solutions/6975305[Service Mesh Operator mirroring failed]. 
warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	modules/olm-mirroring-catalog.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/olm-mirroring-catalog.adoc
CONFLICT (content): Merge conflict in modules/olm-mirroring-catalog.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Adds important admonition and note to disconnected installations when using oc adm catalog and oc image mirror commands
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjpytlak: #51305 failed to apply on top of branch "enterprise-4.10":

Applying: Adds important admonition and note to disconnected installations when using oc adm catalog and oc image mirror commands
.git/rebase-apply/patch:17: trailing whitespace.
Running `oc image mirror` might result in the following error: `error: unable to retrieve source image`. This error occurs when image indexes include references to images that no longer exist on the image registry. Image indexes might retain older references to allow users running those images an upgrade path to newer points on the upgrade graph. As a temporary workaround, you can use the `--skip-missing` option to bypass the error and continue downloading the image index. For more information, see link:https://access.redhat.com/solutions/6975305[Service Mesh Operator mirroring failed]. 
.git/rebase-apply/patch:40: trailing whitespace.
* Running `oc adm catalog mirror` might result in the following error: `error: unable to retrieve source image`. This error occurs when image indexes include references to images that no longer exist on the image registry. Image indexes might retain older references to allow users running those images an upgrade path to newer points on the upgrade graph. As a temporary workaround, you can use the `--skip-missing` option to bypass the error and continue downloading the image index. For more information, see link:https://access.redhat.com/solutions/6975305[Service Mesh Operator mirroring failed]. 
warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	modules/installation-mirror-repository.adoc
M	modules/olm-mirroring-catalog.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/olm-mirroring-catalog.adoc
CONFLICT (content): Merge conflict in modules/olm-mirroring-catalog.adoc
Auto-merging modules/installation-mirror-repository.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Adds important admonition and note to disconnected installations when using oc adm catalog and oc image mirror commands
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.