openshift-docs
openshift-docs copied to clipboard
openshift
[OSDOCS-3974]: new node tuning topic for hosted control planes
Version(s): 4.12
Issue: https://issues.redhat.com/browse/OSDOCS-3974
Link to docs preview (VPN required): http://file.rdu.redhat.com/lahinson/node-tuning-hosted-cps/scalability_and_performance/using-node-tuning-operator.html#node-tuning-hosted-cluster_node-tuning-operator
QE review:
- [ ] QE has approved this change.
Additional information:
🤖 Updated build preview is available at: https://51302--docspreview.netlify.app
Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/3331
Hi @sheriff-rh! As we discussed on Slack a few weeks ago, I've been working on the docs about configuring NTO in hosted control planes (aka HyperShift). When you can, would you mind taking a look at my draft? In particular, let me know if I got any of the NTO-related terminology wrong. Thank you! (Preview link is in the first comment 👆 )
@dagrayvid PTAL at the draft of the docs about configuring NTO in hosted control planes. The preview link is in the first comment 👆
I also asked Andrew Taylor to take a look, since he usually covers the NTO-related docs.
One question: Is Liquan Cui the right person from QE to review this? I'm not sure if I should ask the QE rep for PSAP or for HyperShift.
Thanks!
Thanks @lahinson for the draft. We are expanding on the NTO functionality in HyperShift a bit in this PR which should be landing in the next hours / days (it has been fully approved). That PR includes new docs for the new features, so we should probably include/adapt those project docs into this PR as well.
Thanks for letting me know, @dagrayvid. I'll keep an eye on that PR, and after it's merged, I'll add the new info to this PR.
Thanks for letting me know, @dagrayvid. I'll keep an eye on that PR, and after it's merged, I'll add the new info to this PR.
Thanks @lahinson, the PR has now merged!
@dagrayvid I updated this PR with the additional content. PTAL when you can.
@sheriff-rh I incorporated your feedback, and used what I learned to (hopefully) format the new content from David correctly. Let me know what you think.
@liqcui When you can, please take a look at this new content about node tuning for hosted control planes. The preview link is in the first comment in this PR.
Thank you all!
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thanks a bunch, @sheriff-rh! I learned a lot from your feedback. I made the changes that you mentioned and squashed my commits. I also updated the preview link in the first comment so that you can jump directly to either of the two modules.
Hi @dagrayvid- Any thoughts on the latest draft of the docs? https://51302--docspreview.netlify.app/openshift-enterprise/latest/scalability_and_performance/using-node-tuning-operator.html#node-tuning-hosted-cluster_node-tuning-operator
Hi @lahinson, I will try to do a review today or tomorrow... We do have one pending change to rename a part of the NodePool spec which will impact the documentation, so I would suggest we hold this PR until that has merged.
Thanks @lahinson, based on the guidelines I went through the changes and made my best attempt at deciding the correct formatting for the different object names (Tuned, NodePool, ConfigMap, etc...), though I am open to a second opinion on these!
I also made some other minor suggestions.
Thanks so much, @dagrayvid! I'll go through your revisions and will let you know if I have any questions.
@dagrayvid I incorporated your feedback, and you can see the latest preview here: https://51302--docspreview.netlify.app/openshift-enterprise/latest/scalability_and_performance/using-node-tuning-operator.html#node-tuning-hosted-cluster_node-tuning-operator
PTAL when you can. Thanks!
@dagrayvid Thanks for your additional review! I made the changes that you suggested. Do you think we're at a good place for me to move this forward to be merged?
@dagrayvid Just checking in again. I think we're ready to move this forward to be merged. Any objections before I do that?
Good catch, @jeana-redhat. I added the metadata. Thanks!
/label merge-review-needed
Great! will merge once Travis is done. Thanks :)
/remove-label merge-review-in-progress /remove-label merge-review-needed
@jeana-redhat: new pull request created: #52680
In response to this:
hm :thinking: /cherrypick enterprise-4.12
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
