openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

[OSDOCS-4242]: machine sets are for compute only

Open jeana-redhat opened this issue 2 years ago • 10 comments

Version(s): 4.12+

Issue: OSDOCS-4242

Link to docs preview:

Architecture > Control plane architecture > Machine roles in OpenShift Container Platform

Installing

Post-installation configuration

Support > Troubleshooting > Troubleshooting Windows container workload issues

Storage

Operators > Administrator tasks > Adding Operators to a cluster

Machine management

Nodes

Windows Container support for OpenShift

Scalability and performance

Serverless

Note Some modules I was not able to locate in the preview:

  • modules/installation-osp-dpdk-binding-vfio-pci.adoc
  • modules/installation-osp-setting-worker-affinity.adoc
  • nodes/nodes-machinepools-about.adoc
  • osd_cluster_admin/osd_nodes/osd-nodes-machinepools-about.adoc
  • rosa_cluster_admin/rosa_nodes/rosa-nodes-machinepools-about.adoc

QE review:

  • [ ] QE has approved this change.

Additional information: Background

jeana-redhat avatar Sep 30 '22 20:09 jeana-redhat

🤖 Updated build preview is available at: https://51099--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/2280

ocpdocs-previewbot avatar Sep 30 '22 20:09 ocpdocs-previewbot

lgtm for serverless docs, thanks Jeana!

abrennan89 avatar Oct 06 '22 15:10 abrennan89

@jeana-redhat What you have for Nodes and WINC looks good. Are you going to update the Creating a Windows MachineSet object... assemblies? If so, I have a new assembly that I will update accordingly.

mburke5678 avatar Oct 06 '22 18:10 mburke5678

Thanks @mburke5678! Yes, I have updated the three existing Win machine set topics (here's AWS). So if any new additions can follow that pattern that would be perfect :slightly_smiling_face:

jeana-redhat avatar Oct 06 '22 19:10 jeana-redhat

LGTM for Operators guide. 🚀

adellape avatar Oct 07 '22 14:10 adellape

Performance/Scalability LGTM! :rocket: :sauropod: :clinking_glasses:

sheriff-rh avatar Oct 07 '22 14:10 sheriff-rh

@jeana-redhat thanks for taking this up :) For the https://51099--docspreview.netlify.app/openshift-enterprise/latest/windows_containers/index.html (WINC overview page), I can see 3 instances of machine set. I think it should be compute machine set.

Amrita42 avatar Oct 10 '22 09:10 Amrita42

@jeana-redhat Installing LGTM. Thanks!

mjpytlak avatar Oct 10 '22 18:10 mjpytlak

LGTM for Post install heterogeneous clusters 🚀 Thank you Jeana!

kelbrown20 avatar Oct 13 '22 17:10 kelbrown20

LGTM for storage.

lpettyjo avatar Oct 17 '22 13:10 lpettyjo

@sunzhaohua2 @miyadav @huali9 This is ready for QA review. I have tagged all three of you in case you want to split up the work, but I leave it up to you to decide what approach is least onerous :slightly_smiling_face:

jeana-redhat avatar Oct 18 '22 16:10 jeana-redhat

LGTM, thanks Jeana!

sunzhaohua2 avatar Oct 20 '22 04:10 sunzhaohua2

Machine management LGTM

huali9 avatar Oct 20 '22 12:10 huali9

Thanks @opayne1! Those are some good typo finds lol

jeana-redhat avatar Oct 21 '22 13:10 jeana-redhat

/cherrypick enterprise-4.12

jeana-redhat avatar Oct 21 '22 13:10 jeana-redhat

@jeana-redhat: new pull request created: #52020

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.