openshift-docs
openshift-docs copied to clipboard
RHDEVDOCS-4172 Fixed Issues - Pipelines 1.8 RN
- Aligned team: Dev Tools
- For branches: 4.11+
- Jira: https://issues.redhat.com/browse/RHDEVDOCS-4172
- Direct link to doc preview: https://rolfedh.github.io/previews/RHDEVDOCS-4172/cicd/pipelines/op-release-notes.html#new-features-1-8_op-release-notes
- SME review: @vdemeester @sm43
- QE review: @ppitonak
- Peer review: @bburt-rh
-
/assign @ppitonak /assign @vdemeester /assign @siamaksade Your review and approval is also needed to get this merged.
/hold Hold for Pipelines 1.8 GA on Monday Aug 22.
/lgtm
we need to following points as breaking changes for pipleines as code
1. In Pipeline As Code the default secret key for Repository CRD has been changed, user need to update their Repository with the updated default keys as below
- provider.token - previously token
- webhook.secret - previously secret
2. We now have a special template variable that is able to handle multiple pipelineruns for private repositories support. You would need to change your secret in pipelinerun from :
`secret: pac-git-basic-auth-{{repo_owner}}-{{repo_name}}` to `secret: {{ git_auth_secret }}`
3. tkn-pac CLI is redesigned and a few commands are changed as below
- tkn pac repository create -> tkn pac create repository
- tkn pac repository delete -> tkn pac delete repository
- tkn pac repository list -> tkn pac list
we need to following points as breaking changes for pipleines as code
Updated. Thanks. See:
-
With this update, {pac} renames the default secret keys for the
Repository
custom resource definition (CRD). In your CRD, replacetoken
withprovider.token
, and replacesecret
withwebhook.secret
. -
With this update, {pac} replaces a special template variable with one that supports multiple pipeline runs for private repositories. In your pipeline runs, replace
secret: pac-git-basic-auth-{{repo_owner}}-{{repo_name}}
withsecret: {{ git_auth_secret }}
. -
With this update, {pac} updates the following commands in the
tkn-pac
CLI tool: ** Replacetkn pac repository create
withtkn pac create repository
. ** Replacetkn pac repository delete
withtkn pac delete repository
. ** Replacetkn pac repository list
withtkn pac list
.
just one comment, rest looks good Thank you!
LGTM
/unhold
/lgtm
/cherry-pick enterprise-4.11
/cherry-pick enterprise-4.12
@JStickler: new pull request created: #49454
In response to this:
/cherry-pick enterprise-4.11
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@JStickler: new pull request created: #49455
In response to this:
/cherry-pick enterprise-4.12
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.