openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

BZ2104374: Removed period (.) as supported character from metadata.name

Open mjpytlak opened this issue 2 years ago • 4 comments

Version(s): CP to 4.6+

Issue: This PR addresses BZ2104374

Link to docs preview:

mjpytlak avatar Aug 15 '22 15:08 mjpytlak

@sgaoshang Exact same content from the Nutanix update [1]. Simply updated the conditions to include the change to the respective content in the vSphere and baremetal content.

@pamoedom and @jinyunma Small update to supported characters for metadata.name for vSphere and baremetal. PTAL. Thanks.

[1] https://github.com/openshift/openshift-docs/pull/44537#issuecomment-1191965961

mjpytlak avatar Aug 15 '22 15:08 mjpytlak

/lgtm, thanks

sgaoshang avatar Aug 16 '22 01:08 sgaoshang

@mjpytlak thanks for addressing the issues, I checked that the value of metadata.name is only updated in related docs under Installing on vSphere, also need to update same part under Installing on VMC

jinyunma avatar Aug 16 '22 01:08 jinyunma

also need to update same part under Installing on VMC

Thank you @jinyunma. Updated the VMC content.

mjpytlak avatar Aug 17 '22 14:08 mjpytlak

@mjpytlak thanks for the update, then it looks good to me for vsphere/vmc part.

jinyunma avatar Aug 18 '22 02:08 jinyunma

LGTM for the BM part, thanks @mjpytlak

pamoedom avatar Aug 22 '22 15:08 pamoedom

/cherrypick enterprise-4.12

mjpytlak avatar Aug 29 '22 15:08 mjpytlak

@mjpytlak: new pull request created: #49699

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/cherrypick enterprise-4.11

mjpytlak avatar Aug 29 '22 15:08 mjpytlak

/cherrypick enterprise-4.10

mjpytlak avatar Aug 29 '22 15:08 mjpytlak

/cherrypick enterprise-4.9

mjpytlak avatar Aug 29 '22 15:08 mjpytlak

/cherrypick enterprise-4.8

mjpytlak avatar Aug 29 '22 15:08 mjpytlak

/cherrypick enterprise-4.7

mjpytlak avatar Aug 29 '22 15:08 mjpytlak

@mjpytlak: new pull request created: #49700

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/cherrypick enterprise-4.6

mjpytlak avatar Aug 29 '22 15:08 mjpytlak

@mjpytlak: #49100 failed to apply on top of branch "enterprise-4.10":

Applying: BZ2104374: Removed period (.) as supported character from metadata.name
Using index info to reconstruct a base tree...
M	modules/installation-configuration-parameters.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-configuration-parameters.adoc
CONFLICT (content): Merge conflict in modules/installation-configuration-parameters.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 BZ2104374: Removed period (.) as supported character from metadata.name
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjpytlak: #49100 failed to apply on top of branch "enterprise-4.9":

Applying: BZ2104374: Removed period (.) as supported character from metadata.name
Using index info to reconstruct a base tree...
M	modules/installation-configuration-parameters.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-configuration-parameters.adoc
CONFLICT (content): Merge conflict in modules/installation-configuration-parameters.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 BZ2104374: Removed period (.) as supported character from metadata.name
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjpytlak: #49100 failed to apply on top of branch "enterprise-4.8":

Applying: BZ2104374: Removed period (.) as supported character from metadata.name
Using index info to reconstruct a base tree...
M	modules/installation-configuration-parameters.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-configuration-parameters.adoc
CONFLICT (content): Merge conflict in modules/installation-configuration-parameters.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 BZ2104374: Removed period (.) as supported character from metadata.name
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjpytlak: #49100 failed to apply on top of branch "enterprise-4.7":

Applying: BZ2104374: Removed period (.) as supported character from metadata.name
Using index info to reconstruct a base tree...
M	modules/installation-configuration-parameters.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-configuration-parameters.adoc
CONFLICT (content): Merge conflict in modules/installation-configuration-parameters.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 BZ2104374: Removed period (.) as supported character from metadata.name
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjpytlak: #49100 failed to apply on top of branch "enterprise-4.6":

Applying: BZ2104374: Removed period (.) as supported character from metadata.name
Using index info to reconstruct a base tree...
M	modules/installation-configuration-parameters.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-configuration-parameters.adoc
CONFLICT (content): Merge conflict in modules/installation-configuration-parameters.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 BZ2104374: Removed period (.) as supported character from metadata.name
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.