openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

OADP-311 Node selector usage for velero and restic

Open sbeskin-redhat opened this issue 3 years ago • 5 comments

Resolves: https://issues.redhat.com/browse/OADP-311

OADP 1.1.0

Preview:

sbeskin-redhat avatar Jul 14 '22 13:07 sbeskin-redhat

Velero and Restic pod no longer contains the default limits, I think we can remove this part. https://issues.redhat.com/browse/OADP-648

Specify the value in millicpus or CPU units. Default value is 500m or 1 CPU unit.

Default value is 512Mi.

Default value is 500m or 1 CPU unit.

Default value is 256Mi.

PrasadJoshi12 avatar Aug 17 '22 09:08 PrasadJoshi12

Done

On Wed, Aug 17, 2022 at 11:10 AM PrasadJoshi12 @.***> wrote:

Velero and Restic pod no longer contains the default limits, I think we can remove this part. https://issues.redhat.com/browse/OADP-648

Specify the value in millicpus or CPU units. Default value is 500m or 1 CPU unit.

Default value is 512Mi.

Default value is 500m or 1 CPU unit.

Default value is 256Mi.

— Reply to this email directly, view it on GitHub https://github.com/openshift/openshift-docs/pull/47769#issuecomment-1217723188, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATJEI5OJ36OQ5FIKQEJYRV3VZST67ANCNFSM53SGUVQA . You are receiving this because you were mentioned.Message ID: @.***>

-- *Sasha Beskin (*סשה בסקין) He/His/Him Technical Writer Red Hat Migration and Modernization Solutions Red Hat http://redhat.com Israel

https://static.redhat.com/libs/redhat/brand-assets/2/corp/logo--200.png https://static.redhat.com/libs/redhat/brand-assets/2/corp/logo--200.png @.***

sbeskin-redhat avatar Aug 17 '22 09:08 sbeskin-redhat

Hi, Please take a look now.

On Wed, Aug 17, 2022 at 11:10 AM PrasadJoshi12 @.***> wrote:

Velero and Restic pod no longer contains the default limits, I think we can remove this part. https://issues.redhat.com/browse/OADP-648

Specify the value in millicpus or CPU units. Default value is 500m or 1 CPU unit.

Default value is 512Mi.

Default value is 500m or 1 CPU unit.

Default value is 256Mi.

— Reply to this email directly, view it on GitHub https://github.com/openshift/openshift-docs/pull/47769#issuecomment-1217723188, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATJEI5OJ36OQ5FIKQEJYRV3VZST67ANCNFSM53SGUVQA . You are receiving this because you were mentioned.Message ID: @.***>

-- *Sasha Beskin (*סשה בסקין) He/His/Him Technical Writer Red Hat Migration and Modernization Solutions Red Hat http://redhat.com Israel

https://static.redhat.com/libs/redhat/brand-assets/2/corp/logo--200.png https://static.redhat.com/libs/redhat/brand-assets/2/corp/logo--200.png @.***

sbeskin-redhat avatar Aug 17 '22 09:08 sbeskin-redhat

@PrasadJoshi12 Done, please check

sbeskin-redhat avatar Aug 17 '22 10:08 sbeskin-redhat

@sbeskin-redhat is it possible to attach a generated preview for the docs? there are some changes that we can't see for somewhat on the github preview, and it's extremely hard to review it this way. Thanks in advance.

mperetzred avatar Aug 17 '22 11:08 mperetzred

LGTM but:

  1. Be sure all of your OADP 1.1.0 PRs specify they are for OCP 4.9+, unless there is a soecific reason they are for another set of versions.
  2. Be sure to add a preview for all PRs, especially if you use callouts like <.> -- the reviewer has to see that all the callout numbers work.

RichardHoch avatar Aug 21 '22 13:08 RichardHoch

@sbeskin-redhat could you please publish a preview to this? the github's preview doesn't show the changes that appear on the raw view.

mperetzred avatar Aug 22 '22 06:08 mperetzred

/cherrypick enterprise-4.9

mburke5678 avatar Sep 01 '22 19:09 mburke5678

@mburke5678: new pull request created: #49934

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/cherrypick enterprise-4.10

mburke5678 avatar Sep 01 '22 19:09 mburke5678

/cherrypick enterprise-4.11

mburke5678 avatar Sep 01 '22 19:09 mburke5678

/cherrypick enterprise-4.12

mburke5678 avatar Sep 01 '22 19:09 mburke5678

@mburke5678: new pull request created: #49935

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678: new pull request created: #49936

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678: new pull request created: #49937

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.