openshift-docs
openshift-docs copied to clipboard
[WIP] Reorg the Node and Build secrets files
In researching https://bugzilla.redhat.com/show_bug.cgi?id=2093995, I noticed that there is redundant information about Secrets in a couple of different files:
This PR reorganizes the Node and Build secret files:
-
Replaced the text in CICD -> Builds -> Creating build inputs -> What is a secret? with the text in Understanding secrets from Nodes.
-
Added CICD -> Builds -> Creating build inputs -> Types of secrets from Nodes.
-
Replaced the text in CICD -> Builds -> Creating build inputs -> Updates to secrets with the text in Understanding how to update secrets from Nodes.
-
Added a link after CICD -> Builds -> Creating build inputs -> Creating secrets in Builds to Creating secrets in Node that shows how to configure all secret types.
-
Combined Using secrets from CICD -> Builds -> Creating build inputs (current docs) and Nodes docs (current docs). Using the same module in both assemblies: Creating build inputs and Providing sensitive data to pods by using secrets.
-
Added example secret configurations to CICD -> Builds -> Creating build inputs -> Using secrets from Understanding how to create secret..
Questions:
Should Secret data keys be in builds?
What is the list of types of secrets? The Builds module has 6 types; Nodes has 4 (The dockercfg and dockerconfigjson types are missing).
/lgtm
/remove-lifecycle stale
@mburke5678, is this still valid?
@kalexand-rh WDYT? Are these changes worthwhile to persue?
@kalexand-rh WDYT? Are these changes worthwhile to persue?
I think it's worth rebasing. If that works, it'll be worth putting out for QE. I think the reorg makes sense, and node content has a substantial number of views.
🤖 Updated build preview is available at: https://46882--docspreview.netlify.app
Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/27836
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.
/close
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@openshift-bot: Closed this PR.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting
/reopen. Mark the issue as fresh by commenting/remove-lifecycle rotten. Exclude this issue from closing again by commenting/lifecycle frozen./close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@mburke5678: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/validate-asciidoc | 0b6780d750c9b47de30447361d79f7db642bfe89 | link | true | /test validate-asciidoc |
| ci/prow/deploy-preview | 0b6780d750c9b47de30447361d79f7db642bfe89 | link | true | /test deploy-preview |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.
/close
@openshift-bot: Closed this PR.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting
/reopen. Mark the issue as fresh by commenting/remove-lifecycle rotten. Exclude this issue from closing again by commenting/lifecycle frozen./close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.