openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

[WIP] Reorg the Node and Build secrets files

Open mburke5678 opened this issue 3 years ago • 9 comments

In researching https://bugzilla.redhat.com/show_bug.cgi?id=2093995, I noticed that there is redundant information about Secrets in a couple of different files:

This PR reorganizes the Node and Build secret files:

Questions: Should Secret data keys be in builds? What is the list of types of secrets? The Builds module has 6 types; Nodes has 4 (The dockercfg and dockerconfigjson types are missing).

mburke5678 avatar Jun 21 '22 14:06 mburke5678

/lgtm

coreydaley avatar Jun 22 '22 16:06 coreydaley

/remove-lifecycle stale

@mburke5678, is this still valid?

kalexand-rh avatar Oct 12 '23 17:10 kalexand-rh

@kalexand-rh WDYT? Are these changes worthwhile to persue?

mburke5678 avatar Oct 12 '23 20:10 mburke5678

@kalexand-rh WDYT? Are these changes worthwhile to persue?

I think it's worth rebasing. If that works, it'll be worth putting out for QE. I think the reorg makes sense, and node content has a substantial number of views.

kalexand-rh avatar Oct 12 '23 20:10 kalexand-rh

🤖 Updated build preview is available at: https://46882--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/27836

ocpdocs-previewbot avatar Oct 13 '23 13:10 ocpdocs-previewbot

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-bot avatar Nov 13 '23 00:11 openshift-bot

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot avatar Nov 13 '23 00:11 openshift-merge-robot

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Nov 13 '23 00:11 openshift-ci[bot]

@mburke5678: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate-asciidoc 0b6780d750c9b47de30447361d79f7db642bfe89 link true /test validate-asciidoc
ci/prow/deploy-preview 0b6780d750c9b47de30447361d79f7db642bfe89 link true /test deploy-preview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Mar 22 '24 22:03 openshift-ci[bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-bot avatar Apr 22 '24 00:04 openshift-bot

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Apr 22 '24 00:04 openshift-ci[bot]