openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

[enterprise-4.10] redundant documentation in file registry/securing-exposing-registry.adoc

Open yrro opened this issue 3 years ago • 2 comments

Which section(s) is the issue in?

Exposing the registry

What needs fixing?

This page has two sections. "Exposing a default registry manually". which is basically "patch the image registry operator config to enable the defaultRoute attribute".

But these instructions are also found on the main "Image registry operator operator in OCP" page at https://docs.openshift.com/container-platform/4.10/registry/configuring-registry-operator.html#registry-operator-default-crd_configuring-registry-operator

I think they should only be in the documentation in one place.

As for the next section, "Exposing a secure registry manually". This repeats the same instruction about enabling the default registry route. Then it tells you to patch the image registry operator config to create a new public-routes route (the name is a bit odd using the plural). And this new route is then configured to use a custom TLS server certificate. The result is that you end up with two routes exposing the registry, where only one is needed.

The naming of the sections is a bit odd as it implies that there are two kinds of registries, a "default registry" and a "secure registry".

I think this page ended up suffering from a bit of copy & paste and needs a little bit of cleanup. How about these as sections:

  • Exposing the registry with a default hostname
  • Exposing the registry with a custom hostname
  • Exposing the registry with a custom TLS server certificate

... and removing the redundant instruction to use the defaultRoute attribute when using a custom hostname/certificate?

yrro avatar May 18 '22 07:05 yrro

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Aug 17 '22 01:08 openshift-bot

/remove-lifecycle stale

yrro avatar Aug 17 '22 08:08 yrro

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Nov 15 '22 09:11 openshift-bot

/remove-lifecycle stale /lifecycle frozen

yrro avatar Nov 15 '22 09:11 yrro