openshift-ansible icon indicating copy to clipboard operation
openshift-ansible copied to clipboard

OCPCLOUD-2484,OCPCLOUD-2481: Adds azure and gcp image credential providers

Open theobarberbany opened this issue 1 year ago • 3 comments

Install the azure and gcp image registry credential providers, that are required from 4.16.

theobarberbany avatar Feb 19 '24 15:02 theobarberbany

@theobarberbany: This pull request references OCPCLOUD-2484 which is a valid jira issue.

This pull request references OCPCLOUD-2481 which is a valid jira issue.

In response to this:

Install the azure and gcp image registry credential providers, that are required from 4.16.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Feb 19 '24 15:02 openshift-ci-robot

/retest

theobarberbany avatar Feb 27 '24 10:02 theobarberbany

This covers the 3 major providers, are there any other packages for smaller providers?

@barbacbd There won't be for 4.16, I'm not sure about beyond that.

cc @JoelSpeed

theobarberbany avatar Feb 27 '24 10:02 theobarberbany

This covers the 3 major providers, are there any other packages for smaller providers?

The only three we are concerned about at the moment are AWS, GCP and Azure. These providers had in-tree code which is being switched off. Other providers that we support, that were never in-tree, do not currently support this feature.

JoelSpeed avatar Feb 27 '24 10:02 JoelSpeed

/lgtm

JoelSpeed avatar Feb 27 '24 11:02 JoelSpeed

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barbacbd, JoelSpeed, theobarberbany

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Feb 27 '24 12:02 openshift-ci[bot]

/retest-required

Remaining retests: 0 against base HEAD b0ba95ac847a74cc8631777842732f0b1a115af7 and 2 for PR HEAD a59e04961547ee96d08c35a1129934f783bcf096 in total

openshift-ci-robot avatar Feb 27 '24 13:02 openshift-ci-robot

/retest-required

theobarberbany avatar Mar 05 '24 12:03 theobarberbany

/test e2e-aws-workers-rhel8

theobarberbany avatar Mar 07 '24 13:03 theobarberbany

@theobarberbany: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Mar 07 '24 16:03 openshift-ci[bot]

/cherry-pick 4.15

theobarberbany avatar Apr 09 '24 09:04 theobarberbany

@theobarberbany: cannot checkout 4.15: error checking out "4.15": exit status 1 error: pathspec '4.15' did not match any file(s) known to git

In response to this:

/cherry-pick 4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/cherry-pick release-4.15

theobarberbany avatar Apr 09 '24 09:04 theobarberbany

@theobarberbany: new pull request created: #12498

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/retitle OCPBUGS-32057: Adds azure and gcp image credential providers

barbacbd avatar Apr 10 '24 19:04 barbacbd

@theobarberbany: Jira Issue OCPBUGS-32057: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-32057 has been moved to the MODIFIED state.

In response to this:

Install the azure and gcp image registry credential providers, that are required from 4.16.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot avatar Apr 10 '24 19:04 openshift-bot