openshift-ansible icon indicating copy to clipboard operation
openshift-ansible copied to clipboard

oc csr approver: Configurable number of attempts

Open barbacbd opened this issue 2 years ago • 3 comments

** Added argparsing to allow the user to configure the number of attempts during the oc csr approval process. The default will be 1 just like it was before but this code completes the process to allow user configuration that appeared to be initiated before but was never completed.

barbacbd avatar Jul 11 '22 12:07 barbacbd

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barbacbd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jul 11 '22 12:07 openshift-ci[bot]

/retest

barbacbd avatar Aug 23 '22 13:08 barbacbd

/cc @patrickdillon /uncc

jstuever avatar Oct 12 '22 16:10 jstuever

/retest

barbacbd avatar Oct 28 '22 14:10 barbacbd

@barbacbd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-workers-rhel8 2eb10354d51ee97bce83910a33a4ef03bcbe7e43 link true /test e2e-aws-workers-rhel8

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Oct 28 '22 16:10 openshift-ci[bot]

/retest

barbacbd avatar Nov 23 '22 17:11 barbacbd

/retest

barbacbd avatar Nov 28 '22 13:11 barbacbd

/lgtm

r4f4 avatar Nov 29 '22 15:11 r4f4

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barbacbd, r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Nov 29 '22 15:11 openshift-ci[bot]

@barbacbd: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Nov 29 '22 16:11 openshift-ci[bot]