openshift
Fix mDNS package logging
The logging parameters were set for structured logging (InfoS) in some cases, while Infof is being used (same for Errorf).
Closes: https://issues.redhat.com/browse/USHIFT-263
Which issue(s) this PR addresses:
Closes #<Issue Number>
changes look good to me.
@mangelajo nit: since this is about log change, do you think it is worth adding some debug level log that can be enabled for development testing? one example is I had to add debug all the way down to the server.go handlemDNSPacket to see whether the answer (responder.Answer) is non-zero when debugging the issue: https://github.com/openshift/microshift/pull/833
I'm good with that but let's do it in a separate PR. This is about fixing the bug which has been around for a shameful amount of time I don't want to recognize at this time %).
@ggiguash @zshi-redhat does it look ok to lgtm ? I will be PTO after today.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ggiguash, mangelajo
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [ggiguash,mangelajo]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
/retest-required
Remaining retests: 2 against base HEAD 9466daf6475e3921ec59754d44226a509d03e6ec and 8 for PR HEAD b2e67d01b584b9308566079507a90b0eb4a90f3d in total
/retest-required
Remaining retests: 1 against base HEAD 9466daf6475e3921ec59754d44226a509d03e6ec and 7 for PR HEAD b2e67d01b584b9308566079507a90b0eb4a90f3d in total
/retest-required
Remaining retests: 2 against base HEAD b10d3c87a922e77e006c2fa2b34f636ef9afb94f and 6 for PR HEAD b2e67d01b584b9308566079507a90b0eb4a90f3d in total
/retest-required
Remaining retests: 1 against base HEAD b10d3c87a922e77e006c2fa2b34f636ef9afb94f and 5 for PR HEAD b2e67d01b584b9308566079507a90b0eb4a90f3d in total
/retest-required
Remaining retests: 2 against base HEAD e6980e25714fa6ae188c76aa52615388372e66a3 and 4 for PR HEAD b2e67d01b584b9308566079507a90b0eb4a90f3d in total
/retest-required
Remaining retests: 1 against base HEAD e6980e25714fa6ae188c76aa52615388372e66a3 and 3 for PR HEAD b2e67d01b584b9308566079507a90b0eb4a90f3d in total
@mangelajo: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.