microshift icon indicating copy to clipboard operation
microshift copied to clipboard

PERFSCALE-1818: Initial commit of ansible-microshift automation

Open sjug opened this issue 3 years ago • 3 comments

  • Pre-localhost setup and logging setup
  • Add cadvisor to microshift node, run as service
  • Fix systemd_service var and apply firewall rules sooner
  • Manage prometheus config via template
  • Need to restart cadvisor after CRI-O starts in order to pick up the CRI-O container metrics
  • Split out EPEL repo install and add pbench agent tasks
  • Add pbench to README & pbench_env to vars
  • Set up pbench and kubectl
  • Make pbench-user-benchmark async
  • Updated inventory vars
  • Move API checks to remote node and automate pbench data collection
  • Write three stages of disk usage (pre-install, post-install, post-run) to file
  • Modify timing tasks: reorder and small fixes
  • New disk usage pattern + other small changes
  • Add warm start measurement
  • Rename install-localhost role to setup-localhost for clarity
  • Remove microshift state, unused local cluster state tracking
  • Move into ansible subdir
  • Add something to README.md

Which issue(s) this PR addresses: This PR adds automation to measure the footprint and performance metrics of MicroShift via Ansible scripts.

sjug avatar Aug 09 '22 16:08 sjug

Let's link this to the Jira ticket

/retitle PERFSCALE-1818: Initial commit of ansible-microshift automation

dhellmann avatar Aug 10 '22 13:08 dhellmann

Let's merge the first version of this change. I'm approving it and putting it on hold until @sjug feels convenient to release and merge it. Once merged, we should then discuss our next steps. /hold /lgtm

ggiguash avatar Aug 16 '22 07:08 ggiguash

I've addressed pretty much all the review comments and we're in good shape for the most part. Do you want me to squash and push one commit or do you squash merge?

sjug avatar Aug 16 '22 22:08 sjug

/lgtm

ggiguash avatar Aug 17 '22 12:08 ggiguash

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, sjug

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 17 '22 12:08 openshift-ci[bot]

/unhold

sjug avatar Aug 17 '22 13:08 sjug

@sjug: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 17 '22 13:08 openshift-ci[bot]