openshift
USHIFT-6073: Add upgrade path on releases scenarios: from Z-1
- Add 2 new Release Testing bootc scenarios to exercise Z-1 upgrade path
- Changes
brew-rpmssub dirs fromX.Y-(zstream|ec|rc|nightly)format toX.Y.Z{-(ec|rc|nightly)}to support Z-1 versionsfind_packageoption added tomanage_brew_rpms.shto support it
⚠️ PR https://github.com/openshift/release/pull/72367 must be merged at the same time.
- also backport this to
release-4.20andrelease-4.19
@agullon: This pull request references USHIFT-6073 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: agullon
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [agullon]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@agullon: This pull request references USHIFT-6073 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.
In response to this:
- Add 2 new Release Testing scenarios to exercise Z-1 upgrade path.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@agullon: This pull request references USHIFT-6073 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.
In response to this:
- Add 2 new Release Testing bootc scenarios to exercise Z-1 upgrade path
- Changes
brew-rpmssub dirs fromX.Y-(zstream|ec|rc|nightly)format toX.Y.Z-(ec|rc|nightly)to support Z-1 versions
find_packageoption added tomanage_brew_rpms.shto support it
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@agullon: This pull request references USHIFT-6073 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.
In response to this:
- Add 2 new Release Testing bootc scenarios to exercise Z-1 upgrade path
- Changes
brew-rpmssub dirs fromX.Y-(zstream|ec|rc|nightly)format toX.Y.Z-(ec|rc|nightly)to support Z-1 versions
find_packageoption added tomanage_brew_rpms.shto support it⚠️ PR https://github.com/openshift/release/pull/72367 must be merged at the same time.
- also backport this to
release-4.20andrelease-4.19
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@agullon: This pull request references USHIFT-6073 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.
In response to this:
- Add 2 new Release Testing bootc scenarios to exercise Z-1 upgrade path
- Changes
brew-rpmssub dirs fromX.Y-(zstream|ec|rc|nightly)format toX.Y.Z{-(ec|rc|nightly)}to support Z-1 versions
find_packageoption added tomanage_brew_rpms.shto support it⚠️ PR https://github.com/openshift/release/pull/72367 must be merged at the same time.
- also backport this to
release-4.20andrelease-4.19
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@agullon: This pull request references USHIFT-6073 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.
In response to this:
- Add 2 new Release Testing bootc scenarios to exercise Z-1 upgrade path
- Changes
brew-rpmssub dirs fromX.Y-(zstream|ec|rc|nightly)format toX.Y.Z{-(ec|rc|nightly)}to support Z-1 versions
find_packageoption added tomanage_brew_rpms.shto support it⚠️ PR https://github.com/openshift/release/pull/72367 must be merged at the same time.
- also backport this to
release-4.21,release-4.20andrelease-4.19
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@agullon: This pull request references USHIFT-6073 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.
In response to this:
- Add 2 new Release Testing bootc scenarios to exercise Z-1 upgrade path
- Changes
brew-rpmssub dirs fromX.Y-(zstream|ec|rc|nightly)format toX.Y.Z{-(ec|rc|nightly)}to support Z-1 versions
find_packageoption added tomanage_brew_rpms.shto support it⚠️ PR https://github.com/openshift/release/pull/72367 must be merged first to be able to download Z-1 brew RPMs.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/hold
I would like us to try implementing the same without adding extra options / dimensions to the manage_brew_rpms.sh script (i.e. 0 and 1 flags).
One idea is to always download more than one latest versions, for example the last two. This way, previous version should be handy in the cache if required.
@agullon: This pull request references USHIFT-6073 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.
In response to this:
- Add 2 new Release Testing bootc scenarios to exercise Z-1 upgrade path
- Changes
brew-rpmssub dirs fromX.Y-(zstream|ec|rc|nightly)format toX.Y.Z{-(ec|rc|nightly)}to support Z-1 versionsmanage_brew_rpms.sh download 4.${X} ${OUTPUT_DIR} streamnow downloads internally 4 different versions. Example forX=19:
- Y0_VERSION=4.19.7
- Z1_VERSION=4.19.0
- Y1_VERSION=4.18.26
- Y2_VERSION=4.17.44
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@agullon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-aws-tests-release-arm | 8091e88b42e42183f005d5af833935f36000cf38 | link | true | /test e2e-aws-tests-release-arm |
| ci/prow/e2e-aws-tests-release | 8091e88b42e42183f005d5af833935f36000cf38 | link | true | /test e2e-aws-tests-release |
| ci/prow/e2e-aws-tests-bootc-release-arm | 8091e88b42e42183f005d5af833935f36000cf38 | link | true | /test e2e-aws-tests-bootc-release-arm |
| ci/prow/e2e-aws-tests-bootc-release | 8091e88b42e42183f005d5af833935f36000cf38 | link | true | /test e2e-aws-tests-bootc-release |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@agullon: This pull request references USHIFT-6073 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.
In response to this:
- Add 2 new Release Testing bootc scenarios to exercise Z-1 upgrade path
- Changes
brew-rpmssub dirs fromX.Y-(zstream|ec|rc|nightly)format toX.Y.Z{-(ec|rc|nightly)}to support Z-1 versionsmanage_brew_rpms.sh download 4.${X} ${OUTPUT_DIR} zstreamnow downloads internally 4 different versions: current, Z-1, Y-2 and Y-1. Example forX=19:
- Y0_VERSION=4.19.7
- Z1_VERSION=4.19.0
- Y1_VERSION=4.18.26
- Y2_VERSION=4.17.44
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@agullon: This pull request references USHIFT-6073 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.
In response to this:
- Add 2 new Release Testing bootc scenarios to exercise Z-1 upgrade path
- Changes
brew-rpmssub dirs fromX.Y-(zstream|ec|rc|nightly)format toX.Y.Z{-(ec|rc|nightly)}to support Z-1 versionsmanage_brew_rpms.sh download 4.${X} ${OUTPUT_DIR} zstreamnow downloads internally 4 different versions: current, Z-1, Y-2 and Y-1.
- Example for
X=19:
- Y0_VERSION=4.19.7
- Z1_VERSION=4.19.0
- Y1_VERSION=4.18.26
- Y2_VERSION=4.17.44
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/hold
I would like us to try implementing the same without adding extra options / dimensions to the manage_brew_rpms.sh script (i.e. 0 and 1 flags). One idea is to always download more than one latest versions, for example the last two. This way, previous version should be handy in the cache if required.
@ggiguash can you please review this PR again please? I modified the implementation with your suggestion. See PR description.
Important, CI jobs are using custom S3 bucket to not mess up the cache: AWS_BUCKET_NAME="microshift-build-ushift-6073-cache-us-west-2"