microshift icon indicating copy to clipboard operation
microshift copied to clipboard

[Enhancement] Support DeploymentConfigs

Open cooktheryan opened this issue 3 years ago • 2 comments

What happened:

Attempted to deploy the following

kind: DeploymentConfig
apiVersion: apps.openshift.io/v1 
metadata:
  name: frontend
spec:
  template:
    metadata:
      labels:
        name: frontend
    spec:
      containers:
        - name: helloworld
          image: nginx
  replicas: 5
  selector:
    name: frontend
  strategy:
    type: Rolling
    rollingParams:
      pre:
        failurePolicy: Abort
        execNewPod:
          containerName: helloworld 
          command: [ "/usr/bin/command", "arg1", "arg2" ] 
          env: 
            - name: CUSTOM_VAR1
              value: custom_value1

In events the following err

1s          Warning   Failed                           pod/frontend-2-deploy       Failed to pull image "quay.io/openshift/origin-deployer:unknown": rpc error: code = Unknown desc = Error reading manifest unknown in quay.io/openshift/origin-deployer: manifest unknown: manifest unknown

What you expected to happen:

Deployment config to be deloyed

How to reproduce it (as minimally and precisely as possible):

  1. Create deployment config
  2. check logs

Anything else we need to know?:

Environment:

  • Microshift version (use microshift version): 4.8.0-0.microshift-2021-11-11-151353-3-g49ce62e

  • Hardware configuration: amd64

  • OS (e.g: cat /etc/os-release): RHEL 8.5

  • Kernel (e.g. uname -a): Linux binary-small.example.com 4.18.0-348.el8.x86_64 #1 SMP Mon Oct 4 12:17:22 EDT 2021 x86_64 x86_64 x86_64 GNU/Linux

  • Others:

Relevant Logs

cooktheryan avatar Nov 16 '21 22:11 cooktheryan

This is related to #526 (after fixing some cluster config). The openshift-controller-manager is not coming up with a known good name of a container image for the deploy (or builder) pods. Each deploy config spawn a bespoke pod, given that image tag.

From reproduction:

Containers:
  deployment:
    Container ID:
    Image:          quay.io/openshift/origin-deployer:unknown
    Image ID:

copejon avatar Mar 21 '22 22:03 copejon

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Aug 02 '22 19:08 openshift-bot

We want to keep the set of APIs in MicroShift as small as possible, and therefore do not intend to support the DeploymentConfig API. The list of supported APIs is documented in https://github.com/openshift/microshift/blob/main/docs/enable_apis.md

dhellmann avatar Aug 21 '22 16:08 dhellmann