microshift icon indicating copy to clipboard operation
microshift copied to clipboard

OCPBUGS-38974: Update openvswitch to 3.4

Open npinaeva opened this issue 1 year ago • 14 comments

Following ovn-k and RHCOS updates: https://github.com/openshift/ovn-kubernetes/pull/2273 https://github.com/openshift/os/pull/1596 Depends on: https://issues.redhat.com/browse/ART-10428 previous bump: https://github.com/openshift/microshift/pull/3350

npinaeva avatar Aug 26 '24 15:08 npinaeva

@npinaeva: This pull request references Jira Issue OCPBUGS-38252, which is invalid:

  • expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.17.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Following ovn-k and RHCOS updates: https://github.com/openshift/ovn-kubernetes/pull/2273 https://github.com/openshift/os/pull/1596

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Aug 26 '24 15:08 openshift-ci-robot

@ggiguash similarly to the previous upgrade to 3.3 (https://github.com/openshift/microshift/pull/3350) the tests are failing due to missing --allowerasing, since OVS major varsions cannot be upgraded with a simple dnf install: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_microshift/3816/pull-ci-openshift-microshift-main-metal-bootc-test/1828089113358635008#1:build-log.txt%3A3801 . The failure this time in containerfiles that were not present before. Should they be updated?

igsilya avatar Aug 26 '24 16:08 igsilya

I'm guessing something like this may help resolving the issue:

diff --git a/test/image-blueprints/layer5-bootc/group1/rhel94-bootc-source-ostree-parent.containerfile b/test/image-blueprints/layer5-bootc/group1/rhel94-bootc-source-ostree-parent.containerfile
index 82c285d66..a7a58237b 100644
--- a/test/image-blueprints/layer5-bootc/group1/rhel94-bootc-source-ostree-parent.containerfile
+++ b/test/image-blueprints/layer5-bootc/group1/rhel94-bootc-source-ostree-parent.containerfile
@@ -22,9 +22,12 @@ COPY ./rpm-repos/$USHIFT_RPM_REPO_NAME $USHIFT_RPM_REPO_PATH
 # - MicroShift local RPM repository
 # - OpenShift previous minor version RHEL repositories for MicroShift dependencies
 # Install MicroShift, test agent, a few helper utilities and cleanup
+#
+# Allow erasing because update may require a new version of openvswitch and
+# major versions of openvswitch are separate packages that obsolete each other.
 RUN ${REPO_CONFIG_SCRIPT} -create ${USHIFT_RPM_REPO_PATH} && \
     awk 'FNR==1 {print "=== " FILENAME " ==="} {print}' /etc/yum.repos.d/*.repo && \
-    dnf install -y vi firewalld microshift microshift-test-agent && \
+    dnf install -y --allowerasing vi firewalld microshift microshift-test-agent && \
     systemctl enable microshift microshift-test-agent && \
     ${REPO_CONFIG_SCRIPT} -delete && \
     rm -f ${REPO_CONFIG_SCRIPT} && \

igsilya avatar Aug 26 '24 18:08 igsilya

/retitle OCPBUGS-38974: Update openvswitch to 3.4

ggiguash avatar Aug 27 '24 06:08 ggiguash

@npinaeva: This pull request references Jira Issue OCPBUGS-38974, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @jogeo

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Following ovn-k and RHCOS updates: https://github.com/openshift/ovn-kubernetes/pull/2273 https://github.com/openshift/os/pull/1596 Depends on: https://issues.redhat.com/browse/ART-10428 previous bump: https://github.com/openshift/microshift/pull/3350

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Aug 27 '24 06:08 openshift-ci-robot

/test ?

ggiguash avatar Aug 27 '24 06:08 ggiguash

@ggiguash: The following commands are available to trigger required jobs:

  • /test footprint-and-performance
  • /test images
  • /test metal-bootc-periodic-test
  • /test metal-bootc-periodic-test-arm
  • /test metal-bootc-test
  • /test metal-bootc-test-arm
  • /test metal-periodic-test
  • /test metal-periodic-test-arm
  • /test microshift-metal-cache
  • /test microshift-metal-cache-arm
  • /test microshift-metal-tests
  • /test microshift-metal-tests-arm
  • /test ocp-conformance-rhel-eus
  • /test ocp-conformance-rhel-eus-arm
  • /test ocp-full-conformance-rhel-eus
  • /test test-rpm
  • /test test-unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test test-rebase

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-microshift-main-images
  • pull-ci-openshift-microshift-main-metal-bootc-test
  • pull-ci-openshift-microshift-main-metal-bootc-test-arm
  • pull-ci-openshift-microshift-main-microshift-metal-tests
  • pull-ci-openshift-microshift-main-microshift-metal-tests-arm
  • pull-ci-openshift-microshift-main-test-rpm
  • pull-ci-openshift-microshift-main-test-unit
  • pull-ci-openshift-microshift-main-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Aug 27 '24 06:08 openshift-ci[bot]

/test ocp-conformance-rhel-eus /test ocp-conformance-rhel-eus-arm /test metal-periodic-test /test metal-periodic-test-arm

ggiguash avatar Aug 27 '24 06:08 ggiguash

/test ocp-conformance-rhel-eus /test ocp-conformance-rhel-eus-arm /test metal-periodic-test /test metal-periodic-test-arm

ggiguash avatar Aug 27 '24 10:08 ggiguash

Seeing CDN errors, retrying.

/test metal-periodic-test /test metal-periodic-test-arm

ggiguash avatar Aug 27 '24 10:08 ggiguash

/test ocp-conformance-rhel-eus /test ocp-conformance-rhel-eus-arm /test metal-periodic-test /test metal-periodic-test-arm

npinaeva avatar Aug 27 '24 15:08 npinaeva

/test metal-bootc-test-arm

ggiguash avatar Aug 27 '24 18:08 ggiguash

@npinaeva: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 28 '24 11:08 openshift-ci[bot]

Tested this branch from the MicroShift QE pipeline and everything passed.

jogeo avatar Aug 28 '24 18:08 jogeo

/lgtm /cherry-pick release-4.17

ggiguash avatar Aug 28 '24 19:08 ggiguash

@ggiguash: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to this:

/lgtm /cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, npinaeva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 28 '24 19:08 openshift-ci[bot]

@npinaeva: Jira Issue OCPBUGS-38974: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-38974 has been moved to the MODIFIED state.

In response to this:

Following ovn-k and RHCOS updates: https://github.com/openshift/ovn-kubernetes/pull/2273 https://github.com/openshift/os/pull/1596 Depends on: https://issues.redhat.com/browse/ART-10428 previous bump: https://github.com/openshift/microshift/pull/3350

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Aug 28 '24 19:08 openshift-ci-robot

@ggiguash: new pull request created: #3823

In response to this:

/lgtm /cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.