microshift icon indicating copy to clipboard operation
microshift copied to clipboard

NO-ISSUE: Add 4.15 rhocp repo to configure-vm.sh

Open pacevedom opened this issue 1 year ago • 7 comments

Manually add this repo to the configure-vm.sh script. The get_latest_rhocp_repo has been returning 4.15 and inadvertently enabling that repo until 4.16 went GA and the repo was publicly available. Now that this is the case, the scenario preparation for upgrade tests fails, as there is no repo configured to pull those packages. This PR fixes that by adding not just 4.16 repo, but also 4.15. This is a manual cherry-pick of https://github.com/openshift/microshift/pull/3556

Which issue(s) this PR addresses:

Closes #<Issue Number>

pacevedom avatar Jun 28 '24 17:06 pacevedom

@pacevedom: This pull request explicitly references no jira issue.

In response to this:

Manually add this repo to the configure-vm.sh script. The get_latest_rhocp_repo has been returning 4.15 and inadvertently enabling that repo until 4.16 went GA and the repo was publicly available. Now that this is the case, the scenario preparation for upgrade tests fails, as there is no repo configured to pull those packages. This PR fixes that by adding not just 4.16 repo, but also 4.15. This is a manual cherry-pick of https://github.com/openshift/microshift/pull/3556

Which issue(s) this PR addresses:

Closes #<Issue Number>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 28 '24 17:06 openshift-ci-robot

/lgtm

copejon avatar Jun 28 '24 17:06 copejon

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: copejon, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [copejon,pacevedom]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jun 28 '24 17:06 openshift-ci[bot]

/test microshift-metal-tests

pacevedom avatar Jun 28 '24 18:06 pacevedom

/hold rpm-install needs to update repos, as it does not get the right one now.

pacevedom avatar Jun 28 '24 20:06 pacevedom

New changes are detected. LGTM label has been removed.

openshift-ci[bot] avatar Jun 28 '24 21:06 openshift-ci[bot]

/test microshift-metal-tests

pacevedom avatar Jun 30 '24 21:06 pacevedom

/hold cancel

pacevedom avatar Jul 01 '24 13:07 pacevedom

I believe this will conflict with: https://github.com/openshift/microshift/pull/3513 (in which the tests are passing so it should be fixing the issue present on release-4.16 branch)

pmtk avatar Jul 01 '24 14:07 pmtk

/hold

pmtk avatar Jul 01 '24 14:07 pmtk

@pacevedom: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jul 01 '24 14:07 openshift-ci[bot]

/close

pacevedom avatar Jul 01 '24 16:07 pacevedom

@pacevedom: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Jul 01 '24 16:07 openshift-ci[bot]