microshift icon indicating copy to clipboard operation
microshift copied to clipboard

USHIFT-3511: specify the ocp version when running check-payload

Open eslutsky opened this issue 1 year ago • 12 comments

Which issue(s) this PR addresses:

Closes #<Issue Number>

eslutsky avatar Jun 25 '24 14:06 eslutsky

@eslutsky: This pull request references USHIFT-3511 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature to target the "4.17.0" version, but no target version was set.

In response to this:

Which issue(s) this PR addresses:

Closes #<Issue Number>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 25 '24 14:06 openshift-ci-robot

/test metal-periodic-test

eslutsky avatar Jun 25 '24 14:06 eslutsky

FIPS failed with:

--- Failure Report
+-------------------+--------------------------+-------------------------------------------------------------------------------+
| RPM NAME          | EXECUTABLE NAME          | STATUS                                                                        |
+-------------------+--------------------------+-------------------------------------------------------------------------------+
| cri-tools         | /usr/bin/crictl          | could not find dependent openssl version within container image: libcrypto.so |
| openshift-clients | /usr/bin/oc              | could not find dependent openssl version within container image: libcrypto.so |
| runc              | /usr/bin/runc            | could not find dependent openssl version within container image: libcrypto.so |
| cri-o             | /usr/bin/crio            | could not find dependent openssl version within container image: libcrypto.so |
| microshift        | /usr/bin/microshift      | could not find dependent openssl version within container image: libcrypto.so |
| microshift        | /usr/bin/microshift-etcd | could not find dependent openssl version within container image: libcrypto.so |
+-------------------+--------------------------+-------------------------------------------------------------------------------+

eslutsky avatar Jun 26 '24 15:06 eslutsky

This one needs https://github.com/openshift/check-payload/pull/202/ right?

pacevedom avatar Jun 27 '24 07:06 pacevedom

This one needs openshift/check-payload#202 right?

yes, waiting for the check-payload patch

eslutsky avatar Jun 27 '24 08:06 eslutsky

/lgtm /hold for the check-payload patch to merge

rphillips avatar Jun 27 '24 14:06 rphillips

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eslutsky, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jun 27 '24 14:06 openshift-ci[bot]

check-payload pr merged

/hold cancel

rphillips avatar Jun 27 '24 14:06 rphillips

/retest-required

Remaining retests: 0 against base HEAD a73844cc26a534fe52c43bb197ba95aa71a5345e and 2 for PR HEAD 1a41c1dab7e26bfc0b0f231933da31f1fa79c659 in total

openshift-ci-robot avatar Jun 27 '24 14:06 openshift-ci-robot

@pacevedom @eslutsky the check payload pr (https://github.com/openshift/check-payload/pull/202) is not a blocker for using the -V. The patch is only to print out a warning if -V is not used and recommend users to do so if needed.

ashwindasr avatar Jun 27 '24 14:06 ashwindasr

@eslutsky: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/metal-periodic-test 1a41c1dab7e26bfc0b0f231933da31f1fa79c659 link true /test metal-periodic-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jun 27 '24 15:06 openshift-ci[bot]

/hold this PR is affected by libcrypto issue which is tracked here https://issues.redhat.com/browse/CMP-2639 there is not fix for it yet.

eslutsky avatar Jun 27 '24 16:06 eslutsky

/close its fixed upstream, no longer needed.

eslutsky avatar Jul 01 '24 11:07 eslutsky

@eslutsky: Closed this PR.

In response to this:

/close its fixed upstream, no longer needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Jul 01 '24 11:07 openshift-ci[bot]