microshift icon indicating copy to clipboard operation
microshift copied to clipboard

USHIFT-3139: Release notes job: create tag before referencing it

Open pmtk opened this issue 9 months ago • 6 comments

pmtk avatar May 07 '24 09:05 pmtk

@pmtk: This pull request references USHIFT-3139 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 07 '24 09:05 openshift-ci-robot

/hold

pmtk avatar May 07 '24 09:05 pmtk

This looks good. Another way to do it would be to use the SHA of the new release instead of the tag as the argument to git describe. I like splitting the steps of creating the local tag and pushing the tag, though.

dhellmann avatar May 07 '24 13:05 dhellmann

/unhold

pmtk avatar May 07 '24 13:05 pmtk

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacevedom, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar May 07 '24 15:05 openshift-ci[bot]

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar May 08 '24 08:05 openshift-ci[bot]