microshift icon indicating copy to clipboard operation
microshift copied to clipboard

USHIFT-3138: Refactor scenarios not to exceed 20m runtime in pre-submits

Open ggiguash opened this issue 9 months ago • 15 comments

  • Splitting the osconfig tests to 3 scenarios in bootc only
  • Reduce the amount of restart attempts in the lifecycle test to reduce the overall runtime without hurting the testability
  • Moving certificate rotation test from standard1 to standard2 to balance them out

Note: when we create periodic tests for bootc, we will likely merge the osconfig tests back into one scenario, similar to what we have in composer-cli periodics.

ggiguash avatar May 06 '24 05:05 ggiguash

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar May 06 '24 05:05 openshift-ci[bot]

/test ?

ggiguash avatar May 06 '24 05:05 ggiguash

@ggiguash: The following commands are available to trigger required jobs:

  • /test images
  • /test metal-bootc-test
  • /test metal-bootc-test-arm
  • /test metal-periodic-test
  • /test metal-periodic-test-arm
  • /test microshift-metal-cache
  • /test microshift-metal-cache-arm
  • /test microshift-metal-tests
  • /test microshift-metal-tests-arm
  • /test ocp-conformance-rhel-eus
  • /test ocp-conformance-rhel-eus-arm
  • /test test-rpm
  • /test test-unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test test-rebase

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-microshift-main-images
  • pull-ci-openshift-microshift-main-metal-bootc-test
  • pull-ci-openshift-microshift-main-metal-bootc-test-arm
  • pull-ci-openshift-microshift-main-microshift-metal-tests
  • pull-ci-openshift-microshift-main-microshift-metal-tests-arm
  • pull-ci-openshift-microshift-main-test-unit
  • pull-ci-openshift-microshift-main-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar May 06 '24 05:05 openshift-ci[bot]

/test metal-bootc-test /test metal-bootc-test-arm

ggiguash avatar May 06 '24 05:05 ggiguash

/test metal-bootc-test /test metal-bootc-test-arm

ggiguash avatar May 06 '24 09:05 ggiguash

@ggiguash: This pull request references USHIFT-3138 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 07 '24 05:05 openshift-ci-robot

@ggiguash: This pull request references USHIFT-3138 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

  • Splitting the osconfig tests to 3 scenarios in bootc only
  • Moving certificate rotation test to standard 2 to balance them out

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 07 '24 05:05 openshift-ci-robot

@ggiguash: This pull request references USHIFT-3138 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

  • Splitting the osconfig tests to 3 scenarios in bootc only
  • Moving certificate rotation test from standard1 to standard2 to balance them out

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 07 '24 05:05 openshift-ci-robot

@ggiguash: This pull request references USHIFT-3138 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

  • Splitting the osconfig tests to 3 scenarios in bootc only
  • Reduce the amount of restart attempts in the lifecycle test to reduce the overall runtime without hurting the testability
  • Moving certificate rotation test from standard1 to standard2 to balance them out

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 07 '24 05:05 openshift-ci-robot

@ggiguash: This pull request references USHIFT-3138 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

  • Splitting the osconfig tests to 3 scenarios in bootc only
  • Reduce the amount of restart attempts in the lifecycle test to reduce the overall runtime without hurting the testability
  • Moving certificate rotation test from standard1 to standard2 to balance them out

Note: when we run periodic tests for bootc, we will likely merge the osconfig tests back into one scenario, similar to what we have in composer-cli periodics.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 07 '24 05:05 openshift-ci-robot

@ggiguash: This pull request references USHIFT-3138 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

  • Splitting the osconfig tests to 3 scenarios in bootc only
  • Reduce the amount of restart attempts in the lifecycle test to reduce the overall runtime without hurting the testability
  • Moving certificate rotation test from standard1 to standard2 to balance them out

Note: when we create periodic tests for bootc, we will likely merge the osconfig tests back into one scenario, similar to what we have in composer-cli periodics.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 07 '24 05:05 openshift-ci-robot

/assign @pmtk

ggiguash avatar May 07 '24 05:05 ggiguash

Can we rename the scenario scripts to something more descriptive? Using osconfig1..5 doesn't indicate much outside of a general context for the scenario under test.

copejon avatar May 07 '24 20:05 copejon

/test metal-bootc-test-arm

ggiguash avatar May 08 '24 08:05 ggiguash

@ggiguash: This pull request references USHIFT-3138 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

  • Splitting the osconfig tests to 3 scenarios in bootc only
  • Moving certificate rotation test from standard1 to standard2 to balance them out

Note: when we create periodic tests for bootc, we will likely merge the osconfig tests back into one scenario, similar to what we have in composer-cli periodics.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 09 '24 12:05 openshift-ci-robot

/lgtm

pmtk avatar May 09 '24 12:05 pmtk

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar May 09 '24 12:05 openshift-ci[bot]

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar May 09 '24 15:05 openshift-ci[bot]