microshift icon indicating copy to clipboard operation
microshift copied to clipboard

USHIFT-2924: Add support for gomplate in bootc image and container files

Open ggiguash opened this issue 9 months ago • 15 comments

In addition, optimized the container files by:

  • Merging multiple RUN commands into one to avoid linter errors
  • Switching to using fast-datapath and rhocp repos in rhel images

ggiguash avatar May 04 '24 06:05 ggiguash

@ggiguash: This pull request references USHIFT-2924 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 04 '24 06:05 openshift-ci-robot

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar May 04 '24 06:05 openshift-ci[bot]

/test ?

ggiguash avatar May 04 '24 06:05 ggiguash

@ggiguash: The following commands are available to trigger required jobs:

  • /test images
  • /test metal-bootc-test
  • /test metal-bootc-test-arm
  • /test metal-periodic-test
  • /test metal-periodic-test-arm
  • /test microshift-metal-cache
  • /test microshift-metal-cache-arm
  • /test microshift-metal-tests
  • /test microshift-metal-tests-arm
  • /test ocp-conformance-rhel-eus
  • /test ocp-conformance-rhel-eus-arm
  • /test test-rpm
  • /test test-unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test test-rebase

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-microshift-main-images
  • pull-ci-openshift-microshift-main-metal-bootc-test
  • pull-ci-openshift-microshift-main-metal-bootc-test-arm
  • pull-ci-openshift-microshift-main-metal-periodic-test
  • pull-ci-openshift-microshift-main-metal-periodic-test-arm
  • pull-ci-openshift-microshift-main-microshift-metal-tests
  • pull-ci-openshift-microshift-main-microshift-metal-tests-arm
  • pull-ci-openshift-microshift-main-test-unit
  • pull-ci-openshift-microshift-main-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar May 04 '24 06:05 openshift-ci[bot]

/test metal-bootc-test

ggiguash avatar May 04 '24 06:05 ggiguash

/test metal-bootc-test

ggiguash avatar May 04 '24 06:05 ggiguash

/test metal-bootc-test

ggiguash avatar May 04 '24 07:05 ggiguash

/test verify

ggiguash avatar May 04 '24 07:05 ggiguash

/test metal-bootc-test

ggiguash avatar May 04 '24 07:05 ggiguash

/test verify /test metal-bootc-test

ggiguash avatar May 04 '24 09:05 ggiguash

@ggiguash: This pull request references USHIFT-2924 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

In addition, optimized the container files by:

  • Merging multiple RUN commands into one
  • Switching to using fast-datapath and rhocp repos in rhel images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 04 '24 09:05 openshift-ci-robot

@ggiguash: This pull request references USHIFT-2924 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

In addition, optimized the container files by:

  • Merging multiple RUN commands into one to avoid linter errors
  • Switching to using fast-datapath and rhocp repos in rhel images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 04 '24 09:05 openshift-ci-robot

/assign @pacevedom @pmtk

ggiguash avatar May 06 '24 05:05 ggiguash

These changes LGTM. Will wait for @pmtk to chime in before labeling

copejon avatar May 08 '24 16:05 copejon

Failures not related to the PR changes - saving CI cycles. /override ci/prow/metal-periodic-test-arm

ggiguash avatar May 09 '24 05:05 ggiguash

@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/metal-periodic-test-arm

In response to this:

Failures not related to the PR changes - saving CI cycles. /override ci/prow/metal-periodic-test-arm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar May 09 '24 05:05 openshift-ci[bot]

/lgtm

pmtk avatar May 09 '24 12:05 pmtk

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar May 09 '24 12:05 openshift-ci[bot]

/retest-required

Remaining retests: 0 against base HEAD 24685444c9b85d7933accce19fb1f223443d3525 and 2 for PR HEAD babb466022a17bd4af875245bc20d0214e6ba014 in total

openshift-ci-robot avatar May 09 '24 14:05 openshift-ci-robot

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar May 09 '24 19:05 openshift-ci[bot]