microshift
microshift copied to clipboard
openshift
Correct the GROUP path assignment when calling build_images.sh with -t.
Corrects the GROUP variable value when build_images.sh is called with the -t option.
/lgmt /hold
@jogeo , please attach this PR to a JIRA issue you're working on, or create a separate bug for tracking. You're welcome to unhold the PR once it's linked to the right JIRA.
There is a secondary issue once the group path is set correctly. When -t is passed only one template is built but the code to build the image installer loops over all the files in the directory that have the .image-installer suffix.
I'll keep the /hold until a fix for this is added as well.
@jogeo: This pull request references USHIFT-2372 which is a valid jira issue.
In response to this:
Corrects the GROUP variable value when build_images.sh is called with the -t option.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dhellmann, ggiguash, jogeo, pmtk
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [dhellmann,ggiguash,jogeo,pmtk]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@jogeo: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@ggiguash: new pull request created: #3202
In response to this:
/cherry-pick release-4.15
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
